Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Counterfactual] Deploy safe with first transaction #3185

Merged
merged 16 commits into from
Feb 8, 2024
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Feb 1, 2024

What it solves

Resolves #3184

How this PR fixes it

  • Deploys safe with first transaction
  • Shows gas estimation for the bundle
  • Clear counterfactual state after deployment
  • Hide nonce in all transaction flows

ToDos

  • Adjust AppFrame to handle incoming requests for counterfactual safes

How to test it

  1. Create a counterfactual 1/1 safe
  2. Send some funds to it
  3. Create a transaction
  4. Gas estimation should be displayed
  5. Execute the transaction
  6. Observe you have to sign first
  7. Observe the safe is deployed after execution
  8. Observe the tx history is visible after execution

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 1, 2024

Copy link

github-actions bot commented Feb 1, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 1, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟡 +556 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 64.2 KB (🟡 +14 B) 1.09 MB
/transactions 92.69 KB (🟢 -28 B) 1.11 MB
/transactions/history 92.66 KB (🟢 -28 B) 1.11 MB
/transactions/messages 49.49 KB (🟢 -28 B) 1.07 MB
/transactions/queue 44.59 KB (🟢 -28 B) 1.07 MB
/transactions/tx 34.12 KB (🟢 -28 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.63% (-0.2% 🔻)
11399/14497
🔴 Branches
56.27% (-0.23% 🔻)
2518/4475
🟡 Functions
63.22% (-0.14% 🔻)
1810/2863
🟡 Lines
79.92% (-0.23% 🔻)
10281/12864
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / CounterfactualForm.tsx
72.73% 33.33% 50% 73.02%
🟢
... / useDeployGasLimit.ts
82.35% 66.67% 100% 80%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)
🟡
... / hooks.ts
76.7% (-0.66% 🔻)
61.29% (+0.68% 🔼)
62.5% (-5.92% 🔻)
79.57% (-1.28% 🔻)
🔴
... / utils.ts
40.91% (-32.17% 🔻)
27.27% (-32.73% 🔻)
30% (-30% 🔻)
40% (-32.73% 🔻)
🔴
... / index.tsx
59.85% (+0.59% 🔼)
30.91% (-1.17% 🔻)
24%
59.85% (+0.62% 🔼)
🔴
... / index.tsx
52.94% (-0.18% 🔻)
0% 0%
58.06% (-0.56% 🔻)

Test suite run success

1389 tests passing in 188 suites.

Report generated by 🧪jest coverage report action from a97e3b2

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

github-actions bot commented Feb 5, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM

I tried creating a CF safe, transfer funds to it and then sending them.
After the execution, in the history tab, you can see the safe creation tx and the send funds tx as well.

Copy link

github-actions bot commented Feb 6, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Base automatically changed from cf-safe-creation to dev February 8, 2024 09:56
Copy link

github-actions bot commented Feb 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 8737cb8 into dev Feb 8, 2024
15 checks passed
@usame-algan usame-algan deleted the cf-first-tx branch February 8, 2024 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Counterfactual] Adjust first transaction flow
3 participants