Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: My Accounts page #3233

Merged
merged 18 commits into from
Feb 13, 2024
Merged

Feat: My Accounts page #3233

merged 18 commits into from
Feb 13, 2024

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Feb 9, 2024

What it solves

A simplified version of #3176 w/o a Watchlist, fiat balances and queue counters. Only the new login page, the sidebar is not affected.

The Safes are sorted by current chain and if they are added or not.

Screenshots

Screenshot 2024-02-09 at 14 00 32

How to test it

  • Go to the Welcome page
  • Connect a wallet
  • Press "Continue with Metamask"

If you aleady have owned/added Safes, it will show them.

@katspaugh katspaugh requested a review from jmealy February 9, 2024 13:04
Copy link

github-actions bot commented Feb 9, 2024

Copy link

github-actions bot commented Feb 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 9, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟡 +304 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/welcome/accounts 2.8 KB 1.03 MB

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/welcome 8.68 KB (🟡 +1.59 KB) 1.03 MB
/welcome/social-login 8.73 KB (🟡 +1.18 KB) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.54% (-0.36% 🔻)
11410/14527
🔴 Branches
56.14% (-0.64% 🔻)
2515/4480
🟡 Functions
63.13% (-0.5% 🔻)
1810/2867
🟡 Lines
79.86% (-0.35% 🔻)
10294/12890
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / sessionSlice.ts
70.59% (-11.76% 🔻)
100%
60% (-20% 🔻)
75% (-8.33% 🔻)
🟢
... / useChainId.ts
97.62% (-0.16% 🔻)
92% (-1.1% 🔻)
83.33% (+3.33% 🔼)
100%
🟢
... / useGasPrice.ts
92.31% (-3.08% 🔻)
75.76% (-6.06% 🔻)
90% (-10% 🔻)
93.55% (-1.61% 🔻)
🟢 src/utils/url.ts
85.19% (-3.7% 🔻)
100% 75% 95.65%
🟢
... / index.tsx
96.15% (-0.07% 🔻)
71.43% (-1.9% 🔻)
76.92%
96% (-0.08% 🔻)
🔴
... / utils.ts
46.58% (-1.66% 🔻)
30.77% (-6.73% 🔻)
30%
46.27% (-1.73% 🔻)
🟢
... / useWalletBalance.ts
84.62%
66.67% (-33.33% 🔻)
100% 83.33%
🔴
... / relaying.ts
66.67% (-33.33% 🔻)
0% (-50% 🔻)
0% (-100% 🔻)
50% (-50% 🔻)
🟡
... / CounterfactualForm.tsx
72.73% (-0.8% 🔻)
33.33% (-13.33% 🔻)
50%
73.02% (-0.83% 🔻)
🟡
... / useDeployGasLimit.ts
78.26% (-21.74% 🔻)
11.11% (-77.78% 🔻)
66.67% (-33.33% 🔻)
76.19% (-23.81% 🔻)
🔴
... / index.tsx
46.88% (-35.6% 🔻)
12.5% (-40% 🔻)
9.09% (-63.64% 🔻)
48.89% (-34.63% 🔻)
🟢
... / index.tsx
80% (-20% 🔻)
100%
0% (-100% 🔻)
100%

Test suite run success

1387 tests passing in 188 suites.

Report generated by 🧪jest coverage report action from e643f1a


return (
<Link
href={{ pathname: AppRoutes.newSafe.create, query: { chain: currentChain?.shortName } }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also track this button click? IMO it should be the new entry point for safe creation flow cc @alicecha

Copy link

github-actions bot commented Feb 11, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit 06a35f5 into dev Feb 13, 2024
15 checks passed
@katspaugh katspaugh deleted the my-accounts branch February 13, 2024 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants