Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Counterfactual] Deploy safe with specific version #3238

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Feb 12, 2024

What it solves

Part of #3156

How this PR fixes it

  • Adds a new optional parameter safeVersion to createNewSafe and relaySafeCreation
  • Passes the safeVersion to those functions for undeployed safes

How to test it

  1. Create a new counterfactual safe
  2. Deploy the safe either via first transaction or separate deployment
  3. Observe the safe address is deployed
  4. Create a safe normally
  5. Observe the predicted safe address is the one that is also deployed

Screenshots

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

Copy link

github-actions bot commented Feb 12, 2024

Copy link

github-actions bot commented Feb 12, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 12, 2024

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟑 +41 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/setup 72.07 KB (🟑 +26 B) 1.09 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 12, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements 78.91% 11518/14597
πŸ”΄ Branches
56.82% (+0.04% πŸ”Ό)
2574/4530
🟑 Functions 63.63% 1830/2876
🟒 Lines 80.21% 10388/12951

Test suite run success

1401 tests passing in 190 suites.

Report generated by πŸ§ͺjest coverage report action from 72f791a

@francovenica
Copy link
Contributor

francovenica commented Feb 12, 2024

I tried to execute a tx in this PR but It always fails. Probably the error has nothint to do with the save version field, but it stops me from checking the deployment via "first tx"
Note: I have no problem using the tx that deploy the safe from the settings.

image

@francovenica
Copy link
Contributor

Note:
I just checked and the issue is that I was using Trezor, so is an issue, but it should be tackled in its own ticket.

This one can be passed to Done

@usame-algan usame-algan merged commit 7a0c65b into dev Feb 12, 2024
14 of 15 checks passed
@usame-algan usame-algan deleted the cf-deploy-safe-version branch February 12, 2024 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants