Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add address book pagination tests #3244

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves #3229

How this PR fixes it

  • Added pagination tests for Address Book

Tests added:

  • Verify by default there 25 rows shown per page
  • Verify that clicking on next and previous page buttons shows safes

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Feb 13, 2024

Copy link

github-actions bot commented Feb 13, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 13, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Feb 13, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.88% (-0.02% 🔻)
11512/14594
🔴 Branches
56.84% (-0.02% 🔻)
2573/4527
🟡 Functions
63.61% (-0.03% 🔻)
1830/2877
🟢 Lines
80.2% (-0.02% 🔻)
10384/12948
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1399 tests passing in 190 suites.

Report generated by 🧪jest coverage report action from d7cef3e

@mike10ca mike10ca marked this pull request as ready for review February 13, 2024 10:21
@mike10ca mike10ca merged commit 9371cfe into dev Feb 13, 2024
20 checks passed
@mike10ca mike10ca deleted the address-book-pagination-tests branch February 13, 2024 11:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress tests to remaining address book tests
2 participants