Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't display 0 nonce for grouped txs #3250

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix: don't display 0 nonce for grouped txs #3250

merged 2 commits into from
Feb 15, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3249

How this PR fixes it

Nonce is a number, so 0 wasn't passing the check.

After the fix:
Screenshot 2024-02-13 at 17 08 30

Copy link

github-actions bot commented Feb 13, 2024

Branch preview

⏳ Deploying a preview site...

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 13, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 64.16 KB (🟡 +7 B) 1.09 MB
/transactions 92.65 KB (🟡 +7 B) 1.11 MB
/transactions/history 92.62 KB (🟡 +7 B) 1.11 MB
/transactions/messages 49.45 KB (🟡 +7 B) 1.07 MB
/transactions/queue 44.55 KB (🟡 +7 B) 1.07 MB
/transactions/tx 34.09 KB (🟡 +7 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.88% (-0.02% 🔻)
11512/14594
🔴 Branches
56.84% (-0.02% 🔻)
2573/4527
🟡 Functions
63.61% (-0.03% 🔻)
1830/2877
🟢 Lines
80.2% (-0.02% 🔻)
10384/12948
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1399 tests passing in 190 suites.

Report generated by 🧪jest coverage report action from db7d69d

@liliya-soroka
Copy link
Member

Verified

src/components/transactions/TxSummary/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: Manuel Gellfart <manu@safe.global>
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 37c45f8 into dev Feb 15, 2024
13 of 15 checks passed
@katspaugh katspaugh deleted the fix-nonce branch February 15, 2024 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Conflicting transactions with nonce 0 contain O in the row , as result the row is too big
4 participants