Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change macOsInfo border color #3275

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix: change macOsInfo border color #3275

merged 2 commits into from
Feb 16, 2024

Conversation

TanyaEfremova
Copy link
Contributor

What it solves

Changed the border color of the info alert component on the Notifications tabs in the Settings.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 16, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@katspaugh
@TanyaEfremova
You can retrigger this bot by commenting recheck in this Pull Request

Copy link

github-actions bot commented Feb 16, 2024

Copy link

github-actions bot commented Feb 16, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 16, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.03 MB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/notifications 12.49 KB (🟡 +4 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.7% (+0.04% 🔼)
11583/14717
🔴 Branches
56.77% (+0.05% 🔼)
2591/4564
🟡 Functions
63.64% (+0.22% 🔼)
1843/2896
🟢 Lines
80.04% (-0% 🔻)
10449/13055
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / NoAssets.tsx
55.56% 0% 0% 58.82%
🟡
... / index.tsx
60% 0% 0% 66.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / CheckBalance.tsx
84.21% (-8.65% 🔻)
25%
50% (-50% 🔻)
82.35% (-9.31% 🔻)
🔴
... / utils.ts
36.36% (-1.45% 🔻)
26.83% (-2.12% 🔻)
21.43% (+1.43% 🔼)
36.11% (-2.72% 🔻)
🟢
... / index.tsx
87.5%
70.37% (-2.96% 🔻)
60% 86.54%

Test suite run success

1402 tests passing in 191 suites.

Report generated by 🧪jest coverage report action from 6185272

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Can we merge this if the commit is unverified @katspaugh or will this cause issues in the RC?

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@katspaugh katspaugh merged commit 72ba5cf into dev Feb 16, 2024
12 of 13 checks passed
@katspaugh katspaugh deleted the callcenter branch February 16, 2024 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants