-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set Safe apps categories via URL query #3276
Conversation
Branch preview✅ Deploy successful! |
I noticed that the CoW safe app doesn't have the category |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show new covered files 🐣
Test suite run success1406 tests passing in 192 suites. Report generated by 🧪jest coverage report action from 826de03 |
@@ -74,8 +74,7 @@ const FirstTxFlow = ({ open, onClose }: { open: boolean; onClose: () => void }) | |||
} | |||
|
|||
const onSwap = () => { | |||
// TODO: Pre-filter DeFi category apps | |||
router.push({ pathname: AppRoutes.apps.index, query: router.query }) | |||
router.push({ pathname: AppRoutes.apps.index, query: { ...router.query, categories: 'DEX' } }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add DEX to the SafeAppsTag in constants.ts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think DEX is not the right tag (it only exists on staging). We should probably use DeFi or Aggregator. Afaiu adding it to the SafeAppsTags filters it out in getCategoryOptions
which we need to check if its a valid tag and not some random string.
54d2041
to
10fbd8a
Compare
Screen.Recording.2024-02-19.at.09.59.52.mov |
c628a03
to
393093c
Compare
Can you check again? I pushed a fix |
393093c
to
b127ab3
Compare
# Conflicts: # src/features/counterfactual/FirstTxFlow.tsx
Verified |
What it solves
Resolves #
This is an enhancement for the safe apps list and allows to set categories via the URL. It will be for linking to certain categories like Stake, Bridge, Swap e.g. from the Dashboard.
How this PR fixes it
useCategoryFilter
that checks the URL forcategories
and syncs it with the local stateToDo
useCategoryFilter
How to test it
DEX
apps pre-selectedScreenshots
Checklist