Add copy visual feedback to tx share button #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
katspaugh
reviewed
Feb 20, 2024
katspaugh
reviewed
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3283
How this PR fixes it
It uses the existing CopyTooltip common compoent inside the TxShareLink component.
How to test it
Open http://localhost:3000/transactions/tx?safe=oeth:0x773D7c58941295aF412092efF5Aa3d188525e81a&id=multisig_0x773D7c58941295aF412092efF5Aa3d188525e81a_0x96afb4ae2fc570f3c52f53f820556a430b23ffc610f108d9e549fcf64c99ee3f and click on the Share button
Screenshots
Checklist
Note: At first I added a new ExportTooltip component, then realized it was not necesarry unless the share button changes its action functionality (i.e: doing something other than copying tx url), so reverted first commit and used existing Copytooltip component