fix: Add hide address overflow on transaction history #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
reviewed
Feb 22, 2024
| @@ -62,7 +62,7 @@ const SrcEthHashInfo = ({ | |||
| ) | |||
|
|
|||
| return ( | |||
| <div className={css.container}> | |||
| <div className={css.container} style={{ width: '100%' }}> | |||
There was a problem hiding this comment.
Could you move this style to styles.module.css to the .container class?
There was a problem hiding this comment.
Done! Had not noticed it.
|
This PR also solves issue #3313 , not sure how to add this to the PR description though. |
|
Awesome, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3197
How this PR fixes it
It truncates text with ellipsis on shrink, adding width 100% to TransferTxInfo container (Box) and hiding overflow on SrcEthHashInfo component (text Box itself).
How to test it
Open http://localhost:3000/transactions/history?safe=oeth:0x773D7c58941295aF412092efF5Aa3d188525e81a , open accordion of any transaction and check if address shortens with "..." at the end on smaller viewports.
Screenshots