Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Seedless] Hide tooltip when connected with social signer #3363

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #3266

How this PR fixes it

  • Hides the More network support coming soon toolip

How to test it

  1. Connect with social signer on Gnosis chain
  2. Open the Network selector
  3. Observe other network items are still disabled
  4. Observe there is no tooltip

Screenshots

Screenshot 2024-02-29 at 10 26 05

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

Copy link

github-actions bot commented Feb 29, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1015.79 KB (🟑 +50 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/welcome 6.69 KB (🟑 +48 B) 1022.48 KB
/welcome/social-login 7.16 KB (🟑 +46 B) 1022.95 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements
79.18% (-0.05% πŸ”»)
11498/14522
πŸ”΄ Branches
58.1% (+0.01% πŸ”Ό)
2605/4484
🟑 Functions
64.56% (-0.95% πŸ”»)
1847/2861
🟒 Lines
80.5% (-0.02% πŸ”»)
10358/12867
Show new covered files 🐣
St.❔
File Statements Branches Functions Lines
🟒
... / index.ts
66.67% 100% 100% 100%
🟑
... / Compatibility_fallback_handler__factory.ts
66.67% 100% 0% 66.67%
🟑
... / Create_call__factory.ts
66.67% 100% 0% 66.67%
🟒
... / Gnosis_safe__factory.ts
83.33% 100% 50% 83.33%
🟑
... / Gnosis_safe_l2__factory.ts
66.67% 100% 0% 66.67%
🟒
... / Multi_send__factory.ts
83.33% 100% 50% 83.33%
🟑
... / Multi_send_call_only__factory.ts
66.67% 100% 0% 66.67%
🟒
... / Proxy_factory__factory.ts
83.33% 100% 50% 83.33%
🟑
... / Sign_message_lib__factory.ts
66.67% 100% 0% 66.67%
🟑
... / Simulate_tx_accessor__factory.ts
66.67% 100% 0% 66.67%
πŸ”΄
... / ERC20__factory.ts
56.25% 0% 28.57% 56.25%
πŸ”΄
... / ERC721__factory.ts
50% 0% 14.29% 50%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
50% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
50% 100% 100% 100%
🟒
... / Gnosis_safe__factory.ts
83.33% 100% 50% 83.33%
🟑
... / Proxy_factory__factory.ts
66.67% 100% 0% 66.67%
🟒
... / index.ts
50% 100% 100% 100%
🟑
... / Default_callback_handler__factory.ts
66.67% 100% 0% 66.67%
πŸ”΄
... / Gnosis_safe__factory.ts
50% 100% 0% 50%
🟒
... / Multi_send__factory.ts
83.33% 100% 50% 83.33%
πŸ”΄
... / Proxy_factory__factory.ts
50% 100% 0% 50%
🟒
... / index.ts
50% 100% 100% 100%
πŸ”΄
... / Gnosis_safe__factory.ts
50% 100% 0% 50%
🟒
... / index.ts
50% 100% 100% 100%
πŸ”΄
... / Compatibility_fallback_handler__factory.ts
50% 100% 0% 50%
πŸ”΄
... / Create_call__factory.ts
50% 100% 0% 50%
πŸ”΄
... / Multi_send__factory.ts
50% 100% 0% 50%
πŸ”΄
... / Multi_send_call_only__factory.ts
50% 100% 0% 50%
🟒
... / Safe__factory.ts
83.33% 100% 50% 83.33%
🟑
... / Safe_l2__factory.ts
66.67% 100% 0% 66.67%
🟑
... / Safe_proxy_factory__factory.ts
66.67% 100% 0% 66.67%
πŸ”΄
... / Sign_message_lib__factory.ts
50% 100% 0% 50%
πŸ”΄
... / Simulate_tx_accessor__factory.ts
50% 100% 0% 50%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
50% 100% 100% 100%
🟒
... / AllowanceModule__factory.ts
83.33% 100% 50% 83.33%
🟒
... / index.ts
100% 100% 100% 100%
🟒
... / index.ts
50% 100% 100% 100%
🟑
... / AddModulesLib__factory.ts
66.67% 100% 0% 66.67%
🟑
... / Safe4337Module__factory.ts
66.67% 100% 0% 66.67%
🟒
... / transactions.ts
100% 100% 100% 100%
πŸ”΄
... / e2e-wallet.ts
29.41% 100% 0% 38.46%
🟑
... / test-utils.tsx
71.79% 66.67% 50% 71.05%
🟒
... / safe.ts
100% 100% 100% 100%
🟒
... / Builder.ts
100% 100% 100% 100%
🟒
... / utils.ts
100% 100% 100% 100%
🟑
... / safeTx.ts
68.75% 100% 44.44% 66.67%
🟒
... / wallet.ts
100% 100% 100% 100%
🟒
... / eip1193Provider.ts
100% 100% 100% 100%
🟒
... / chains.ts
91.43% 100% 86.67% 93.94%
🟒
... / messages.ts
100% 100% 100% 100%
🟒
... / chains.ts
100% 100% 100% 100%
🟒
... / transactions.ts
100% 50% 100% 100%
πŸ”΄
... / contractManager.ts
43.33% 60% 14.29% 41.38%
Show files with reduced coverage πŸ”»
St.❔
File Statements Branches Functions Lines
🟑
... / useConnectWallet.ts
66.67% (-3.33% πŸ”»)
0% 50%
63.64% (-3.03% πŸ”»)
🟒
... / index.tsx
87.76% (+6.4% πŸ”Ό)
73.33% (-1.67% πŸ”»)
100% (+33.33% πŸ”Ό)
90.91% (+7.58% πŸ”Ό)

Test suite run success

1407 tests passing in 194 suites.

Report generated by πŸ§ͺjest coverage report action from 864e028

@usame-algan usame-algan merged commit 65a946a into dev Mar 1, 2024
13 checks passed
@usame-algan usame-algan deleted the social-signer-tooltip branch March 1, 2024 07:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable social login buttons for all chains but Gnosis
2 participants