Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not possible to click on a safe in listItem #3373

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

compojoom
Copy link
Contributor

@compojoom compojoom commented Mar 1, 2024

Since the .listItem had a padding, the tag inside of it was only clickable if you manage to hit it directly. But ListItem actually looks like a clickable button, so you won’t expect that you have to be clicking directly in the center.

What it solves

Since a picture is worth 1000 words, a gif is worth ????

2024-03-01 10 08 20

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

Since the .listItem had a padding, the <a> tag inside of it was only clickable if you manage to hit it directly. But ListItem actually looks like a clickable button, so you won’t expect that you have to be clicking directly in the center.
Copy link

github-actions bot commented Mar 1, 2024

Copy link

github-actions bot commented Mar 1, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 1, 2024

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1015.85 KB (🟑 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™Œ

Copy link

github-actions bot commented Mar 1, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements
79.22% (-0.19% πŸ”»)
11130/14049
πŸ”΄ Branches
58.08% (-0.12% πŸ”»)
2598/4473
🟑 Functions
65.51% (-0.51% πŸ”»)
1789/2731
🟒 Lines
80.52% (-0.15% πŸ”»)
10026/12451
Show new covered files 🐣
St.❔
File Statements Branches Functions Lines
πŸ”΄
... / wallets.ts
34.62% 0% 0% 43.9%
Show files with reduced coverage πŸ”»
St.❔
File Statements Branches Functions Lines
🟑
... / useConnectWallet.ts
66.67% (-3.33% πŸ”»)
0% 50%
63.64% (-3.03% πŸ”»)
🟒
... / index.tsx
81.36% (-6.4% πŸ”»)
75% (+1.67% πŸ”Ό)
66.67% (-33.33% πŸ”»)
83.33% (-7.58% πŸ”»)

Test suite run success

1408 tests passing in 194 suites.

Report generated by πŸ§ͺjest coverage report action from 4213867

@compojoom compojoom merged commit bec4d5e into dev Mar 1, 2024
13 checks passed
@compojoom compojoom deleted the fix-clicking-on-safe branch March 1, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants