Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: if there are local safes redirect from index route / to accounts page #3376

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Mar 1, 2024

What it solves

  • Allow users to access their locally stored safes without requiring them to connect a wallet.
  • redirect automatically to the accounts page if the user connects a wallet via the wallet connect button on the /welcome page. This change was included in this PR but the redirect is not working.

How this PR fixes it

When a user visits the main route of the site, check if they have safes in localstorage.

  • if they do, redirect to /welcome/accounts
  • if they don't redirect to /welcome as before
  • redirect to the login page (/wecome/accounts) when a user explicitly connects using the wallet connect button on the welcome page.

@jmealy jmealy requested a review from katspaugh March 1, 2024 12:49
Copy link

github-actions bot commented Mar 1, 2024

Copy link

github-actions bot commented Mar 1, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 1, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1015.87 KB (🟡 +11 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 461 B (🟡 +42 B) 1016.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Mar 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.42% (-0.02% 🔻)
11107/13986
🔴 Branches
58.2% (-0.02% 🔻)
2594/4457
🟡 Functions
66.03% (-0.02% 🔻)
1790/2711
🟢 Lines
80.68% (-0.02% 🔻)
10003/12399
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1407 tests passing in 194 suites.

Report generated by 🧪jest coverage report action from 373808b

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there's a failing test.

@@ -8,6 +8,11 @@ const WalletLogin = ({ onLogin }: { onLogin: () => void }) => {
const wallet = useWallet()
const connectWallet = useConnectWallet()

const onConnectWallet = () => {
connectWallet()
onLogin()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jmealy jmealy merged commit c838db1 into dev Mar 4, 2024
13 checks passed
@jmealy jmealy deleted the login-redirect branch March 4, 2024 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants