Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recovery not visible on settings page #3414

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: Recovery not visible on settings page #3414

merged 1 commit into from
Mar 12, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #3413

How this PR fixes it

  • For some safe proxy contracts (e.g. on mainnet), the function getGnosisProxyMasterCopy returns 0 since the public masterCopy function is missing (Example)
  • Check isAddress for a given moduleAddress before running _getZodiacContract

How to test it

  1. Open a safe on mainnet that added another safe as the recoverer
  2. Navigate to the settings page
  3. Observe the Recovery setup is visible

Screenshots

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

Copy link

github-actions bot commented Mar 7, 2024

Copy link

github-actions bot commented Mar 7, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 7, 2024

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

This PR introduced no changes to the JavaScript bundle! πŸ™Œ

Copy link

github-actions bot commented Mar 7, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements
79.38% (-0% πŸ”»)
11127/14018
πŸ”΄ Branches
58.37% (-0.01% πŸ”»)
2609/4470
🟑 Functions 66.03% 1792/2714
🟒 Lines
80.64% (+0% πŸ”Ό)
10023/12430
Show files with reduced coverage πŸ”»
St.❔
File Statements Branches Functions Lines
🟑
... / delay-modifier.ts
65.91% (+0.06% πŸ”Ό)
22.22% (-2.78% πŸ”»)
50%
65.85% (+1.75% πŸ”Ό)

Test suite run success

1410 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from 632086c

Copy link
Contributor

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks ok to me

@liliya-soroka
Copy link
Member

@usame-algan , the recovery is not displayed for the safe from the support ticket

@liliya-soroka
Copy link
Member

Verified

@usame-algan usame-algan merged commit 7c21e54 into dev Mar 12, 2024
14 checks passed
@usame-algan usame-algan deleted the fix-recovery branch March 12, 2024 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Recovery not showing up after setup
3 participants