Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix recover test #3421

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Tests: fix recover test #3421

merged 11 commits into from
Mar 13, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Mar 12, 2024

What it solves

How this PR fixes it

  • This task improves recovery tests by using API calls. It also adds some waits to help the tests run.
  • We are still facing issues with timeouts from external which out of our control. This will be addressed later.

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Mar 12, 2024

Copy link

github-actions bot commented Mar 12, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Mar 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.38% (+0% 🔼)
11125/14015
🔴 Branches
58.38% (+0.01% 🔼)
2609/4469
🟡 Functions 66.03% 1792/2714
🟢 Lines
80.63% (-0% 🔻)
10021/12428
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / delay-modifier.ts
65.85% (-0.06% 🔻)
25% (+2.78% 🔼)
50%
64.1% (-1.75% 🔻)
🟢
... / index.tsx
89.29% (-0.37% 🔻)
88.89% 50%
88.46% (-0.43% 🔻)

Test suite run success

1410 tests passing in 195 suites.

Report generated by 🧪jest coverage report action from a64a58e

Copy link

github-actions bot commented Mar 13, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mike10ca mike10ca marked this pull request as ready for review March 13, 2024 14:08
Copy link
Contributor

@francovenica francovenica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike10ca mike10ca merged commit dd6c3cc into dev Mar 13, 2024
14 of 17 checks passed
@mike10ca mike10ca deleted the fix-recovery-test branch March 13, 2024 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants