-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't allow duplicate signers in safe creation #3427
Conversation
Branch previewβ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
π¦ Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. π€
|
Page | Size (compressed) |
---|---|
global |
1016.32Β KB (π‘ +278Β B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Four Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/new-safe/create |
32.35Β KB (π’ -487Β B) |
1.02Β MB |
/new-safe/load |
18.49Β KB (π’ -489Β B) |
1.01Β MB |
/transactions |
89.07Β KB (π’ -500Β B) |
1.08Β MB |
/transactions/history |
89.03Β KB (π’ -500Β B) |
1.08Β MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage π»
Test suite run success1411 tests passing in 195 suites. Report generated by π§ͺjest coverage report action from 0b1a360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it really helps to merge these components π
Could we add a test for this new fix? There is a AddressBookInput unit test already.
I created a e2e test for this. I'll make my PR once this ticket is merged to dev |
# Conflicts: # src/components/common/AddressInputReadOnly/index.tsx
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What it solves
Resolves #3415
The fix implemented in #3060 added a new
onChange
call to theAutocomplete
to render theAddressInputReadOnly
whenever the user selects an address book entry in the input field and display validation errors in this separate component.However if a
deps
array is also passed toAddressBookInput
it triggers a revalidation which is not propagated becauseAddressInputReadOnly
is rendered instead ofAddressInput
.How this PR fixes it
AddressInputReadOnly
intoAddressInput
AddressInput
useChain
hookHow to test it
Make sure that the fix from #3060 is still working:
Check that other places where
AddressInput
andAddressBookInput
are used are still workingScreenshots
Checklist