fix: allow subscribing to owned but not added safes #3429

jmealy · 2024-03-12T16:22:50Z

What it solves

Resolves #3288

How this PR fixes it

Do not show added but not owned safes in global notification settings.
Show owned safes plus added & owned safes.
Remove the notification banner completely.

How to test it

Go to the settings->notifications -> global preferences
You should see the option to add notifications to only safes that are owned by the connected wallet.

Observe that the notification banner does not show up under any conditions.

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions · 2024-03-12T16:23:05Z

Branch preview

✅ Deploy successful!

https://subscribe--walletweb.review-wallet-web.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

github-actions · 2024-03-12T16:23:55Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-03-12T16:26:38Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`994.07 KB` (🟢 -22.26 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps`	`50.94 KB` (🟡 +4.15 KB)	1.02 MB
`/apps/custom`	`42.56 KB` (🟡 +4.15 KB)	1.01 MB
`/apps/open`	`66.79 KB` (🟡 +2.89 KB)	1.04 MB
`/balances`	`29.91 KB` (🟡 +7 B)	1023.98 KB
`/balances/nfts`	`23.31 KB` (🟡 +2.89 KB)	1017.38 KB
`/home`	`57.14 KB` (🟡 +4.24 KB)	1.03 MB
`/new-safe/create`	`35.24 KB` (🟡 +2.89 KB)	1.01 MB
`/new-safe/load`	`21.38 KB` (🟡 +2.89 KB)	1015.45 KB
`/settings/notifications`	`28 KB` (🔴 +16.05 KB)	1022.07 KB
`/settings/security-login`	`30.48 KB` (🟡 +7 B)	1 MB
`/transactions`	`91.97 KB` (🟡 +2.89 KB)	1.06 MB
`/transactions/history`	`91.94 KB` (🟡 +2.88 KB)	1.06 MB
`/transactions/messages`	`51.65 KB` (🟡 +2.88 KB)	1.02 MB
`/transactions/queue`	`47.25 KB` (🟡 +2.88 KB)	1.02 MB
`/transactions/tx`	`36.6 KB` (🟡 +2.88 KB)	1.01 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-03-12T16:34:57Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.36% (-0.11% 🔻)	11049/13923
🔴	Branches	58.26% (-0.26% 🔻)	2598/4459
🟡	Functions	65.91% (-0.24% 🔻)	1779/2699
🟢	Lines	80.66% (-0.08% 🔻)	9951/12337

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / useAllOwnedSafes.ts	44.44%	0%	0%	57.14%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟡	`...` / sdk.ts	69.05% (-7.14% 🔻)	35.29% (-9.15% 🔻)	72.73% (-2.27% 🔻)	68% (-9.03% 🔻)
🟡	`...` / wallets.ts	62.86% (-3.81% 🔻)	25%	75% (-2.78% 🔻)	65.52% (-3.23% 🔻)
🔴	`...` / useOnboard.ts	50.38% (-0.4% 🔻)	23.81%	15%	52.99% (-0.52% 🔻)
🟢	`...` / useChains.ts	100%	50% (-50% 🔻)	100%	100%
🟡	`...` / addedSafesSlice.ts	63.16% (-21.05% 🔻)	50%	41.67% (-41.67% 🔻)	67.74% (-16.13% 🔻)
🟢	`...` / WalletConnectWallet.ts	90.48% (-0.22% 🔻)	90.48% (-1.19% 🔻)	84%	92.5% (-0.18% 🔻)
🟢	`...` / index.tsx	100%	85% (-1.36% 🔻)	100%	100%
🟢	`...` / index.tsx	100%	86.36% (-1.14% 🔻)	100%	100%
🟢	`...` / index.tsx	100%	95% (-0.56% 🔻)	100%	100%
🟢	`...` / index.tsx	93.02% (+0.72% 🔼)	88.24% (-3.43% 🔻)	76.92% (+1.92% 🔼)	94.74% (+0.62% 🔼)
🟢	`...` / index.tsx	86.67% (-13.33% 🔻)	66.67% (-33.33% 🔻)	33.33% (-66.67% 🔻)	85.71% (-14.29% 🔻)
🟢	`...` / index.tsx	87.76% (-0.24% 🔻)	73.33%	100%	90.91% (-0.2% 🔻)
🟢	`...` / index.tsx	83.33% (-1.85% 🔻)	100%	33.33% (-26.67% 🔻)	82.61% (-2.01% 🔻)
🟡	src/pages/404.tsx	68.75%	64.29% (-7.14% 🔻)	50%	71.43%

Test suite run success

1401 tests passing in 194 suites.

Report generated by 🧪jest coverage report action from cdbaf19

… notification settings

restore removed test

github-actions · 2024-03-13T16:37:39Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

usame-algan

Considering that we have the notification feature for a while now, how complex the PushNotificationBanner component is and that we already received feedback in the past to reduce the number of popups I would be in favour of removing it completely. Lets discuss it with the team.

src/components/settings/PushNotifications/GlobalPushNotifications.tsx

cypress/e2e/regression/add_owner.cy.js

src/components/settings/PushNotifications/PushNotificationsBanner/index.tsx

usame-algan · 2024-03-18T09:08:45Z

@jmealy discussed it this morning and others are also in favour of removing the banner. @katspaugh suggests to rename the "Settings" button to "Push notification settings"

jmealy · 2024-03-20T08:45:22Z

@jmealy discussed it this morning and others are also in favour of removing the banner. @katspaugh suggests to rename the "Settings" button to "Push notification settings"

brilliant, thanks Usame 🙏

github-actions · 2024-03-21T10:03:45Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

usame-algan · 2024-03-21T14:21:49Z

@mike10ca do we need to update something in Testrail now that the Push Notification Banner has been removed?

mike10ca · 2024-03-21T14:25:05Z

@mike10ca do we need to update something in Testrail now that the Push Notification Banner has been removed?

@usame-algan no, since automation does not cover notifications to date.

francovenica · 2024-03-22T05:50:26Z

Are we renaming this button as "Push notifications settings" or I missunderstood and it will remain as "settings"?

francovenica · 2024-03-22T06:40:57Z

The rest looks good

Safe you added but don't own doesn't show up in the global settings
The notification popUp doesn't show up anymore (checked for CF safes after deployed as well)
Tested notifications in general (incomming, outgoing tx and tx that need signing)

If the button will remain as "Settings" then the ticket can be merged. If not, change the test and don't put it in QA, just merge it

use owned safes for global notifications settings

0e4972a

show merged notified and owned safes

c40e4b1

jmealy added 4 commits March 13, 2024 15:06

fix: only show notification popup for owned safes

e795495

Show added safes, owned safes, and currently notified safes in global…

9e8eb6e

… notification settings

fix unit tests

544069b

Restore removed unit test

c8a538a

restore removed test

jmealy added 3 commits March 14, 2024 11:54

Adismiss notification banner flag for cypress tests

cb0dfb6

use set for getting unique array

80faa20

remove duplicate comment

8d7750d

jmealy marked this pull request as ready for review March 14, 2024 11:19

jmealy requested review from katspaugh and usame-algan March 14, 2024 11:20

usame-algan reviewed Mar 15, 2024

View reviewed changes

src/components/settings/PushNotifications/GlobalPushNotifications.tsx Outdated Show resolved Hide resolved

cypress/e2e/regression/add_owner.cy.js Outdated Show resolved Hide resolved

src/components/settings/PushNotifications/PushNotificationsBanner/index.tsx Outdated Show resolved Hide resolved

remove notification banner

12be11e

jmealy added 2 commits March 21, 2024 11:06

revert changes to tests

d2e41ae

update unit tests

9ab7607

jmealy requested a review from usame-algan March 21, 2024 11:05

usame-algan approved these changes Mar 21, 2024

View reviewed changes

rename notifications -> Push notification settings

cdbaf19

jmealy merged commit e973dfd into dev Mar 22, 2024
14 checks passed

jmealy deleted the subscribe branch March 22, 2024 08:50

github-actions bot locked and limited conversation to collaborators Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow subscribing to owned but not added safes #3429

fix: allow subscribing to owned but not added safes #3429

jmealy commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 13, 2024 •

edited

usame-algan left a comment

usame-algan commented Mar 18, 2024

jmealy commented Mar 20, 2024

github-actions bot commented Mar 21, 2024 •

edited

usame-algan commented Mar 21, 2024

mike10ca commented Mar 21, 2024

francovenica commented Mar 22, 2024

francovenica commented Mar 22, 2024

fix: allow subscribing to owned but not added safes #3429

fix: allow subscribing to owned but not added safes #3429

Conversation

jmealy commented Mar 12, 2024 • edited

What it solves

How this PR fixes it

How to test it

Checklist

github-actions bot commented Mar 12, 2024 • edited

Branch preview

github-actions bot commented Mar 12, 2024 • edited

ESLint Summary View Full Report

github-actions bot commented Mar 12, 2024 • edited

📦 Next.js Bundle Analysis for safe-wallet-web

🎉 Global Bundle Size Decreased

Fifteen Pages Changed Size

github-actions bot commented Mar 12, 2024 • edited

Coverage report

Test suite run success

github-actions bot commented Mar 13, 2024 • edited

ESLint Summary View Full Report

usame-algan left a comment

Choose a reason for hiding this comment

usame-algan commented Mar 18, 2024

jmealy commented Mar 20, 2024

github-actions bot commented Mar 21, 2024 • edited

ESLint Summary View Full Report

usame-algan commented Mar 21, 2024

mike10ca commented Mar 21, 2024

francovenica commented Mar 22, 2024

francovenica commented Mar 22, 2024

jmealy commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 13, 2024 •

edited

github-actions bot commented Mar 21, 2024 •

edited