-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: always switch wallet chain before signing/executing #3440
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1016.35 KB (🟡 +33 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1411 tests passing in 195 suites. Report generated by 🧪jest coverage report action from 150f257 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "could not decode result data" error is gone but I am still getting a "SafeProxy not deployed" error:
It originates from the getUncheckedSafeSDK
function where we call sdk.connect
. I checked if maybe the chainIds don't match but they are all the same. Tested this with the 1.3.0 safe on mainnet from the slack request.
@usame-algan what are the steps to reproduce this? |
Tested first on prod to see the issue. I noticed that during safe creation it doesn't check if it is in the current network or not. In this PR it does and asks for the network to be changed to the current network the safe is in (the "change to NETWORK" button shows in the safe creation) LGTM |
What it solves
The Zerion Wallet mobile app, when connected via WalletConnect, connects to the wrong chain but onboard thinks it's on the right chain. In addition to that,
onboard.setChain
doesn't work for WalletConnect (probably because onboard thinks there's no need to switch the chain). Not sure on whose side is the bug, but this fixes it for us.Basically, if we detect WalletConnect, it will always attempt to switch the chain even if it's seemingly already on the right one.
How to test
Other cases: