Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove counterfactual backup option #3446

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: Remove counterfactual backup option #3446

merged 2 commits into from
Mar 18, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Follow up on #3203

Less than 4% of users who created a counterfactual safe did a backup according to our analytics. Furthermore we received feedback that this option is confusing. As there is currently no strategy to restore those backups this option seems more confusing than it is useful. In case users with an existing backup reach out to us we can still handle those manually.

How to test it

  1. Create a new counterfactual safe
  2. Observe no Backup option

Screenshots

Screenshot 2024-03-15 at 15 13 47

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

@usame-algan usame-algan requested a review from jmealy March 15, 2024 14:13
Copy link

github-actions bot commented Mar 15, 2024

Copy link

github-actions bot commented Mar 15, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 15, 2024

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.9 KB (🟒 -79 B) 1.02 MB
/home 52.88 KB (🟒 -494 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Mar 15, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements 79.38% 11122/14011
πŸ”΄ Branches 58.4% 2610/4469
🟑 Functions 66.1% 1794/2714
🟒 Lines 80.64% 10018/12423

Test suite run success

1411 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from 345006b

@@ -41,7 +40,7 @@ export const defaultSepoliaPlaceholder = 'Sepolia Safe'
const welcomeToSafeStr = 'Welcome to Safe'

export function verifyNewSafeDialogModal() {
main.verifyElementsIsVisible([safeBackupAlert, dialogConfirmBtn])
main.verifyElementsIsVisible([dialogConfirmBtn])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike10ca I have to adjust this line in order for the test to work again since the backup option for counterfactual safes is removed in this PR.

@liliya-soroka
Copy link
Member

Verified

@usame-algan usame-algan merged commit 98ed66d into dev Mar 18, 2024
14 checks passed
@usame-algan usame-algan deleted the remove-backup branch March 18, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants