-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove counterfactual backup option #3446
Conversation
Branch previewβ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
π¦ Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. π€ Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Test suite run success1411 tests passing in 195 suites. Report generated by π§ͺjest coverage report action from 345006b |
@@ -41,7 +40,7 @@ export const defaultSepoliaPlaceholder = 'Sepolia Safe' | |||
const welcomeToSafeStr = 'Welcome to Safe' | |||
|
|||
export function verifyNewSafeDialogModal() { | |||
main.verifyElementsIsVisible([safeBackupAlert, dialogConfirmBtn]) | |||
main.verifyElementsIsVisible([dialogConfirmBtn]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike10ca I have to adjust this line in order for the test to work again since the backup option for counterfactual safes is removed in this PR.
Verified |
What it solves
Follow up on #3203
Less than 4% of users who created a counterfactual safe did a backup according to our analytics. Furthermore we received feedback that this option is confusing. As there is currently no strategy to restore those backups this option seems more confusing than it is useful. In case users with an existing backup reach out to us we can still handle those manually.
How to test it
Screenshots
Checklist