fix: Overlapping buttons when signing a transaction #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Code looks good, thank you! Could you sign the CLA as per the bot message above? |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Thank you 🙏 |
katspaugh
approved these changes
Mar 25, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Overlapping buttons when signing a transaction #3403
Resolves #3403
How this PR fixes it:
As per the designs provided removed box component and used stack component to achieve the responsive design for different screen widths. Added media queries for respective screen sizes to render the buttons as asked in the design.
How to test it
Tested on various devices, screen sizes also by resizing the window.
Screenshots
Checklist