New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint rules #3475
Update eslint rules #3475
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
12d827a
to
b0d44d8
Compare
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Test suite run success1404 tests passing in 194 suites. Report generated by 🧪jest coverage report action from e32c567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've fixed the failing test on another branch.
b0d44d8
to
e32c567
Compare
What it solves
Reduces nitpicking on syntax during reviews.
Ads rules for enforcing shortharnd object notation and removing curly brace when having a single prop e.g.
something={"somtihng"}
becomessometihng="something"
I also tried adding jsx-newline, but it conflicts with prettier and there doesn't seem to be a setting that can make those 2 co-exist. So I gues nitpicking on non-readable jsx syntax is fine there :).