Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint rules #3475

Merged
merged 2 commits into from Apr 3, 2024
Merged

Update eslint rules #3475

merged 2 commits into from Apr 3, 2024

Conversation

compojoom
Copy link
Contributor

What it solves

Reduces nitpicking on syntax during reviews.

Ads rules for enforcing shortharnd object notation and removing curly brace when having a single prop e.g.
something={"somtihng"} becomes sometihng="something"

I also tried adding jsx-newline, but it conflicts with prettier and there doesn't seem to be a setting that can make those 2 co-exist. So I gues nitpicking on non-readable jsx syntax is fine there :).

Copy link

github-actions bot commented Mar 25, 2024

Copy link

github-actions bot commented Mar 25, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 25, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 66.8 KB (🟡 +1 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Mar 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.38% 11081/13960
🔴 Branches 58.45% 2614/4472
🟡 Functions 65.94% 1785/2707
🟢 Lines 80.69% 9981/12370

Test suite run success

1404 tests passing in 194 suites.

Report generated by 🧪jest coverage report action from e32c567

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've fixed the failing test on another branch.

@compojoom compojoom merged commit 320a2b7 into dev Apr 3, 2024
14 checks passed
@compojoom compojoom deleted the update-eslint-rules branch April 3, 2024 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants