Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show Safe activation status in safe list #3493

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Mar 28, 2024

What it solves

Resolves #3492

How this PR fixes it

Displays a Chip in the Safe List either saying "Not activated" or "Activating account" depending on the deployment status of a Safe

How to test it

  1. Create a counterfactual safe
  2. Open the Sidebar and observe a new Chip saying "Not activated"
  3. Activate the Safe
  4. Open the Sidebar and observe the same Chip saying "Activating account" with a different color and loading spinner
  5. The same should be visible on the login page
  6. Already deployed safes should not be affected by this
  7. Watchlist safes should not be affected by this

Screenshots

Screenshot 2024-03-28 at 11 10 35 Screenshot 2024-03-28 at 11 11 38

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

@usame-algan usame-algan requested a review from jmealy March 28, 2024 10:10
Copy link

github-actions bot commented Mar 28, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 28, 2024

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 999.42 KB (🟑 +1.74 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 48.05 KB (🟒 -2.89 KB) 1.02 MB
/apps/custom 39.67 KB (🟒 -2.88 KB) 1.01 MB
/apps/open 76.44 KB (🟒 -2.89 KB) 1.05 MB
/balances 29.91 KB (🟒 -6 B) 1.01 MB
/balances/nfts 20.43 KB (🟒 -2.89 KB) 1019.85 KB
/home 55.13 KB (🟒 -2.89 KB) 1.03 MB
/new-safe/create 32.35 KB (🟒 -2.89 KB) 1.01 MB
/new-safe/load 18.49 KB (🟒 -2.89 KB) 1017.91 KB
/settings/security-login 30.48 KB (🟒 -7 B) 1.01 MB
/transactions 101.71 KB (🟒 -2.88 KB) 1.08 MB
/transactions/history 101.68 KB (🟒 -2.88 KB) 1.08 MB
/transactions/messages 61.29 KB (🟒 -2.89 KB) 1.04 MB
/transactions/queue 56.99 KB (🟒 -2.88 KB) 1.03 MB
/transactions/tx 46.34 KB (🟒 -2.88 KB) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Mar 28, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements
79.11% (-0.02% πŸ”»)
11217/14179
πŸ”΄ Branches
58.66% (-0.02% πŸ”»)
2663/4540
🟑 Functions
66.06% (-0.04% πŸ”»)
1804/2731
🟒 Lines
80.39% (-0.02% πŸ”»)
10108/12574
Show files with reduced coverage πŸ”»
St.❔
File Statements Branches Functions Lines
🟒
... / index.tsx
82.35% (-8.82% πŸ”»)
66.67% (-16.67% πŸ”»)
50% (-12.5% πŸ”»)
83.87% (-9.68% πŸ”»)

Test suite run success

1421 tests passing in 198 suites.

Report generated by πŸ§ͺjest coverage report action from 5e97229

Copy link

github-actions bot commented Apr 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@francovenica
Copy link
Contributor

Nice! It was a pain not to know if you already have a not-deployed safe

LGTM

# Conflicts:
#	src/features/counterfactual/CounterfactualStatusButton.tsx
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit d5b0e10 into dev Apr 10, 2024
14 checks passed
@usame-algan usame-algan deleted the safe-list-status branch April 10, 2024 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display activation status in the Safe list
3 participants