-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show Safe activation status in safe list #3493
Conversation
Branch previewβ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
π¦ Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. π€
|
Page | Size (compressed) |
---|---|
global |
999.42Β KB (π‘ +1.74Β KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fourteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/apps |
48.05Β KB (π’ -2.89Β KB) |
1.02Β MB |
/apps/custom |
39.67Β KB (π’ -2.88Β KB) |
1.01Β MB |
/apps/open |
76.44Β KB (π’ -2.89Β KB) |
1.05Β MB |
/balances |
29.91Β KB (π’ -6Β B) |
1.01Β MB |
/balances/nfts |
20.43Β KB (π’ -2.89Β KB) |
1019.85Β KB |
/home |
55.13Β KB (π’ -2.89Β KB) |
1.03Β MB |
/new-safe/create |
32.35Β KB (π’ -2.89Β KB) |
1.01Β MB |
/new-safe/load |
18.49Β KB (π’ -2.89Β KB) |
1017.91Β KB |
/settings/security-login |
30.48Β KB (π’ -7Β B) |
1.01Β MB |
/transactions |
101.71Β KB (π’ -2.88Β KB) |
1.08Β MB |
/transactions/history |
101.68Β KB (π’ -2.88Β KB) |
1.08Β MB |
/transactions/messages |
61.29Β KB (π’ -2.89Β KB) |
1.04Β MB |
/transactions/queue |
56.99Β KB (π’ -2.88Β KB) |
1.03Β MB |
/transactions/tx |
46.34Β KB (π’ -2.88Β KB) |
1.02Β MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage π»
Test suite run success1421 tests passing in 198 suites. Report generated by π§ͺjest coverage report action from 5e97229 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Nice! It was a pain not to know if you already have a not-deployed safe LGTM |
# Conflicts: # src/features/counterfactual/CounterfactualStatusButton.tsx
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What it solves
Resolves #3492
How this PR fixes it
Displays a Chip in the Safe List either saying "Not activated" or "Activating account" depending on the deployment status of a Safe
How to test it
Screenshots
Checklist