Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Counterfactual] Show pending status on dashboard #3495

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Mar 28, 2024

What it solves

Resolves #3494

How this PR fixes it

  • Shows a different title and a loading spinner on the dashboard when activating a safe
  • Shows a Pending status widget on the dashboard when activating a safe
  • Shows a Useful Information widget on the dashboard when activating a safe

Out of scope

Not included in this PR but coming later is an additional screen in case the activation is taking too long and an option to speed-up the transaction. See Figma design.

How to test it

  1. Create a counterfactual safe
  2. Go to the dashboard
  3. Activate the safe
  4. Observe a new loading state

Screenshots

Screenshot 2024-03-28 at 12 05 00

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan changed the title feat: [Counterfactual] Show pending status on dashboard when activating a safe feat: [Counterfactual] Show pending status on dashboard Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Mar 28, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 997.68 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/home 58.02 KB (🟡 +660 B) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Mar 28, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.11% 11217/14179
🔴 Branches 58.66% 2663/4540
🟡 Functions 66.06% 1804/2731
🟢 Lines 80.39% 10108/12574

Test suite run success

1421 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 7604b7f

@francovenica
Copy link
Contributor

LGTM.

Question regarding this:

Not included in this PR but coming later is an additional screen in case the activation is taking too long and an option to speed-up the transaction. See Figma design.

Right now is not possible to speed up tx with no signatures, and I assume that the safe creation is the same as other tx where the signature is not there at the moment of execution. So, it will be possible to use speed up in this type of tx?

Copy link

github-actions bot commented Apr 10, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

Right now is not possible to speed up tx with no signatures, and I assume that the safe creation is the same as other tx where the signature is not there at the moment of execution. So, it will be possible to use speed up in this type of tx?

Since we require the user to sign the safe creation tx I think speed-up will always be an option there.

Btw. I just noticed a bug with the widget not changing when relaying the transaction but it should be fixed now.

@usame-algan usame-algan merged commit 1135117 into dev Apr 10, 2024
14 checks passed
@usame-algan usame-algan deleted the safe-activation-dashboard branch April 10, 2024 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Counterfactual] Display activation status on the dashboard
3 participants