Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: migrate the relay API #3514

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Refactor: migrate the relay API #3514

merged 4 commits into from
Apr 11, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3351

How this PR fixes it

I've replaced the old API calls with the new Gateway functions.

@katspaugh katspaugh requested a review from iamacook April 4, 2024 14:06
Copy link

github-actions bot commented Apr 4, 2024

Copy link

github-actions bot commented Apr 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Apr 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 997.53 KB (🟢 -121 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 78.51 KB (🟡 +36 B) 1.05 MB
/new-safe/create 35.25 KB (🟡 +7 B) 1.01 MB
/transactions 103.79 KB (🟡 +36 B) 1.08 MB
/transactions/history 103.76 KB (🟡 +36 B) 1.08 MB
/transactions/messages 63.37 KB (🟡 +36 B) 1.04 MB
/transactions/queue 59.07 KB (🟡 +36 B) 1.03 MB
/transactions/tx 48.41 KB (🟡 +36 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Apr 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.12% (-0.02% 🔻)
11186/14138
🔴 Branches
58.57% (-0.11% 🔻)
2652/4528
🟡 Functions
66.03% (-0.02% 🔻)
1802/2729
🟢 Lines
80.41% (-0.02% 🔻)
10079/12535
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / dispatch.ts
40.56% (+0.33% 🔼)
40% (-3.48% 🔻)
30%
39.88% (+0.36% 🔼)
🟡
... / index.ts
69.67%
59.09% (-3.41% 🔻)
47.06% 68.87%

Test suite run success

1419 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from be5c868

src/services/tx/relaying.ts Show resolved Hide resolved
Copy link

github-actions bot commented Apr 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

I tested in sepolia since GNO is only in the prod cgw.

I tried several transaction with different wallets and different safe policies using and not using the relayer
I run out of relayer uses both in tx and safe creation
Check the relayer attempts work per safe. Also per owner in the safe creation

LGTM

@katspaugh katspaugh merged commit 99357e4 into dev Apr 11, 2024
14 checks passed
@katspaugh katspaugh deleted the relay branch April 11, 2024 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the Relay service to CGW
3 participants