Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: reject tx events #3516

Merged
merged 4 commits into from Apr 8, 2024
Merged

Analytics: reject tx events #3516

merged 4 commits into from Apr 8, 2024

Conversation

katspaugh
Copy link
Member

What it solves

A few events for the new Delete Transaction feature.

Screenshot 2024-04-05 at 16 27 43
  • Replace tx button – on click on the first button
  • Reject onchain button – second button
  • Delete offchain button – the new delete button

Screenshot 2024-04-05 at 16 28 35
  • Delete cancel – when "Keep it" is clicked or wallet signature rejected
  • Delete confirm – on "Yes, delete"
  • Delete success – on success
  • Delete fail – on error

@katspaugh katspaugh requested a review from alicecha April 5, 2024 14:29
Copy link

github-actions bot commented Apr 5, 2024

Copy link

github-actions bot commented Apr 5, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Apr 5, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 997.65 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Apr 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.06% 11192/14157
🔴 Branches 58.25% 2641/4534
🟡 Functions 65.97% 1801/2730
🟢 Lines 80.34% 10086/12554

Test suite run success

1411 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 92e613b

Copy link

@alicecha alicecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked. All good.

@katspaugh katspaugh merged commit 23d14db into dev Apr 8, 2024
14 checks passed
@katspaugh katspaugh deleted the reject-events branch April 8, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants