Feat: show balances in the Safe List #3546

katspaugh · 2024-04-10T16:28:05Z

What it solves

Resolves #3610

How this PR fixes it

I've added @iamacook's new endpoint for balances and pending transaction counts (the counts aren't displayed yet), as well as an infinite scroll pagination for the safe list.

Gateway SDK PR: safe-global/safe-gateway-typescript-sdk#161

Fiat formatting

I've also adjusted the currency formatting function a bit: it will now not show cents for amounts greater than 1k.

github-actions · 2024-04-10T16:28:19Z

Branch preview

✅ Deploy successful!

Website:
https://safe_list--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://safe_list--walletweb.review.5afe.dev/storybook/

github-actions · 2024-04-10T16:31:38Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-04-10T16:34:26Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1010.45 KB` (🟡 +2.17 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps`	`46.54 KB` (🟢 -46 B)	1.03 MB
`/apps/custom`	`38.17 KB` (🟢 -42 B)	1.02 MB
`/apps/open`	`74.03 KB` (🟢 -1.09 KB)	1.06 MB
`/balances`	`29.87 KB` (🟢 -46 B)	1.02 MB
`/balances/nfts`	`20.26 KB` (🟢 -172 B)	1.01 MB
`/home`	`59.7 KB` (🟢 -67 B)	1.05 MB
`/new-safe/create`	`32.22 KB` (🟡 +6 B)	1.02 MB
`/new-safe/load`	`18.35 KB` (🟡 +6 B)	1 MB
`/transactions`	`101.46 KB` (🟢 -205 B)	1.09 MB
`/transactions/history`	`101.42 KB` (🟢 -205 B)	1.09 MB
`/transactions/messages`	`61.24 KB` (🟢 -198 B)	1.05 MB
`/transactions/queue`	`56.55 KB` (🟢 -533 B)	1.04 MB
`/transactions/tx`	`46.38 KB` (🟢 -40 B)	1.03 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-04-10T16:35:21Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.33% (-0.01% 🔻)	11327/14278
🔴	Branches	58.74% (+0.01% 🔼)	2681/4564
🟡	Functions	66.49% (+0.01% 🔼)	1835/2760
🟢	Lines	80.62% (+0.01% 🔼)	10202/12655

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / useAllOwnedSafes.ts	41.18% (-3.27% 🔻)	0%	0%	50% (-7.14% 🔻)
🟢	`...` / useLoadBalances.ts	91.11% (-2.07% 🔻)	66.67%	100%	95%

Test suite run success

1426 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 33debac

github-actions · 2024-04-22T11:01:53Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

jmealy

The balances on mobile are not positioned:

…e-list

github-actions · 2024-04-26T06:55:10Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

katspaugh · 2024-04-26T07:21:33Z

@jmealy fixed, thank you!

jmealy

Looks good ✨

katspaugh · 2024-04-26T12:17:00Z

Added pending actions also:

francovenica · 2024-05-06T12:37:34Z

The "To confirm" tag shows whenever there is a tx that you (as connected owner) have not signed, even for safes 1/x, so technically there is nothing to confirm there. I'd say that, for safes 1/x the tag should not show.

Question:
Currently in prod, if you are not connected with an owner, no safes are shown (except in the watch list). Now it seems the safes I saw with a connected owner are being stored so even if I'm not connected the full list loads.
Is this an intended change? maybe for the new pagination?

…e-list

github-actions · 2024-05-06T13:31:53Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

katspaugh · 2024-05-06T13:41:21Z

Fixed the cached list on disconnect, figuring out the "1 to confirm" thing with Aaron.

katspaugh · 2024-05-07T13:01:06Z

@francovenica Aaron has fixed it on the CGW side. 👍

francovenica · 2024-05-08T12:09:29Z

The List of safes being unloaded when the user disconnected looks good

The other issue still persist:
The user still see the "1 to confirm" even tho the current connected user cannot confirm it
Steps:
Create a safe 1/2
Queue a tx with Owner1
Connect with Owner2
Check the safe in the login page

Since the tx is fully confirmed, neither owner1 or owner2 should see the "1 to confirm". Only the "1 pending tx" tag should show

iamacook · 2024-05-08T12:18:02Z

The user still see the "1 to confirm" even tho the current connected user cannot confirm it

I am looking into this issue from the backend perspective now.

Edit: a fix has been put into review on our end. I've tested it as per your reproduction steps and it solves the issue. I'll inform you when it's live.

github-actions · 2024-05-08T13:05:14Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

iamacook · 2024-05-08T13:29:52Z

@francovenica, the "1 to confirm" issue appears to be solved now that we've merged the fix on our end.

francovenica · 2024-05-08T13:52:27Z

@iamacook Yes. It works fine now.

LGTM

Feat: show balances in the Safe List

af5c3a3

katspaugh requested a review from jmealy April 10, 2024 16:28

katspaugh added 3 commits April 22, 2024 12:41

Rm alpha

e45ebe5

Pull from dev

65f752a

Use FiatValue component

e11a339

katspaugh added 2 commits April 22, 2024 14:53

Adjust currency formatting

b0da85c

Update package

e88ddd4

katspaugh force-pushed the safe-list branch from 7aa157a to e88ddd4 Compare April 22, 2024 13:39

katspaugh marked this pull request as ready for review April 22, 2024 13:56

Leftover packages; page size

881c231

katspaugh force-pushed the safe-list branch from 3b6a95b to 881c231 Compare April 22, 2024 13:59

jmealy requested changes Apr 22, 2024

View reviewed changes

katspaugh marked this pull request as draft April 22, 2024 16:09

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into saf…

e326030

…e-list

Use grid

7cf0f65

jmealy approved these changes Apr 26, 2024

View reviewed changes

Cache owned safes

9de2b20

katspaugh marked this pull request as ready for review April 26, 2024 08:00

katspaugh added 2 commits April 26, 2024 10:08

Update gateway SDK

79702bb

Add pending actions

b2fb280

katspaugh force-pushed the safe-list branch from c5d3953 to b2fb280 Compare April 26, 2024 11:47

katspaugh added 2 commits April 26, 2024 13:59

Queue action links

8a126c3

Update gateway SDK

0a6012d

katspaugh added 2 commits May 6, 2024 15:00

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into saf…

5129994

…e-list

Fix: reset owned safes on wallet disconnect

189dc3c

katspaugh added 2 commits May 7, 2024 15:03

Pull from dev

da3fb9d

Pull from dev

bcec460

Pull from dev

8eee284

katspaugh force-pushed the safe-list branch from c8369e1 to e20bc68 Compare May 8, 2024 13:25

Resolve ENS names in Safe List

c71279d

katspaugh force-pushed the safe-list branch from e20bc68 to c71279d Compare May 8, 2024 13:27

katspaugh force-pushed the safe-list branch from 1d8323c to 76ced01 Compare May 8, 2024 14:21

ENS resolver adjustment

33debac

katspaugh force-pushed the safe-list branch from 76ced01 to 33debac Compare May 8, 2024 14:24

katspaugh merged commit 77b9bda into dev May 8, 2024
13 of 14 checks passed

katspaugh deleted the safe-list branch May 8, 2024 14:40

github-actions bot locked and limited conversation to collaborators May 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: show balances in the Safe List #3546

Feat: show balances in the Safe List #3546

katspaugh commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 22, 2024 •

edited

jmealy left a comment

github-actions bot commented Apr 26, 2024 •

edited

katspaugh commented Apr 26, 2024

jmealy left a comment

katspaugh commented Apr 26, 2024

francovenica commented May 6, 2024

github-actions bot commented May 6, 2024 •

edited

katspaugh commented May 6, 2024

katspaugh commented May 7, 2024

francovenica commented May 8, 2024

iamacook commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

iamacook commented May 8, 2024

francovenica commented May 8, 2024

Feat: show balances in the Safe List #3546

Feat: show balances in the Safe List #3546

Conversation

katspaugh commented Apr 10, 2024 • edited

What it solves

How this PR fixes it

Fiat formatting

github-actions bot commented Apr 10, 2024 • edited

Branch preview

github-actions bot commented Apr 10, 2024

ESLint Summary View Full Report

github-actions bot commented Apr 10, 2024 • edited

📦 Next.js Bundle Analysis for safe-wallet-web

⚠️ Global Bundle Size Increased

Thirteen Pages Changed Size

github-actions bot commented Apr 10, 2024 • edited

Coverage report

Test suite run success

github-actions bot commented Apr 22, 2024 • edited

ESLint Summary View Full Report

jmealy left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2024 • edited

ESLint Summary View Full Report

katspaugh commented Apr 26, 2024

jmealy left a comment

Choose a reason for hiding this comment

katspaugh commented Apr 26, 2024

francovenica commented May 6, 2024

github-actions bot commented May 6, 2024 • edited

ESLint Summary View Full Report

katspaugh commented May 6, 2024

katspaugh commented May 7, 2024

francovenica commented May 8, 2024

iamacook commented May 8, 2024 • edited

github-actions bot commented May 8, 2024 • edited

ESLint Summary View Full Report

iamacook commented May 8, 2024

francovenica commented May 8, 2024

katspaugh commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

github-actions bot commented Apr 22, 2024 •

edited

github-actions bot commented Apr 26, 2024 •

edited

github-actions bot commented May 6, 2024 •

edited

iamacook commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited