fix: [Counterfactual] Call onSubmit handler when submitting a transaction

[usame-algan]

What it solves

We didn't call the onSubmit handler in CounterfactualForm so safe apps didn't receive a safeTxHash when submitting transactions.

How this PR fixes it

• Call onSubmit when submitting in CounterfactualForm

How to test it

1. Create a counterfactual safe
2. Send some WETH to it
3. Open the CowSwap safe app
4. Create a TWAP order
5. Submit the transaction in the tx-flow
6. Observe that CowSwap shows a success message and is not stuck

Checklist

• I've tested the branch on mobile 📱
• I've documented how it affects the analytics (if at all) 📊
• I've written a unit/e2e test for it (if applicable) 🧑‍💻

[github-actions]

Branch preview

✅ Deploy successful!

https://cf_onsubmit--walletweb.review-wallet-web.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[usame-algan]

This is not ideal but also doesn't break anything. We can adjust the type but we are prop drilling this handler multiple times and will have to change it in all of these places and adjust related logic.

[katspaugh]

Can it be Math.random() instead?

[github-actions]

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	79.08% (-0.01% 🔻)	11194/14155
🔴	Branches	58.52%	2649/4527
🟡	Functions	66.03%	1802/2729
🟢	Lines	80.36% (-0.01% 🔻)	10087/12552

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟡	... / CounterfactualForm.tsx	69.12% (-1.03% 🔻)	42.86%	66.67%	69.23% (-1.08% 🔻)

Test suite run success

1419 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 7901544

[usame-algan]

This fixes the issue mentioned here cowprotocol/cowswap#4063 (comment)

[francovenica]

Tried to swap WETH for USDC and I got a timeout on the tx and now the app is stuck here:

The cowSwap app still shows a tx is pending in the UI, but the address never got any order in cowswap at all:
https://explorer.cow.fi/sepolia/address/0xd134A0150f82C11f2B4368Ee0fA8133Fa450b5a6

Also the link to the tx in the sepolia block explorer is emtpy as well:
https://sepolia.etherscan.io/tx/0x22f82e47fd2f4564b5af08d81f4f98dd3481af78c3203996643c7bea3cf9a877

[francovenica]

A sideeffect of this is that the safe seems to have been deployed or at least "the safe thinks so".

If I try to do a send funds I get the "Safe already deployed" even tho no tx are present in the queue or history at all, and the sidebar still shows the "not deployed" icon

[francovenica]

Given Usame's advice I tried again with Rabby and this time it worked. I was able to do the token approval for swapping + safe activation just fine and then tried the swap (the swap end up failing for low amount being swapped, so it was expected)

The safe used:
https://cf_onsubmit--walletweb.review-wallet-web.5afe.dev/transactions/history?safe=sep:0xfeAacD8DDFb0E9B26136971C244e782b2EB05675

So, the ticket is fine, but given that most people use MM they might find the issue I reported first.

[notion-workspace]

Swap in CF safes - The swap is not performed when is done as “first tx”

[notion-workspace]

Swap in CF safes - The swap is not performed when is done as “first tx”

[notion-workspace]

Swap in CF safes - The swap is not performed when is done as “first tx”

[usame-algan]

I will merge this so the CoW team is unblocked but we should follow up on this once Metamask works again.