fix: Hide "add to address book" when address already in the address book #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
reviewed
Apr 14, 2024
| @@ -35,6 +35,11 @@ const AddressBookInput = ({ name, canAdd, ...props }: AddressInputProps & { canA | |||
| [addressBookEntries, addressValue], | |||
| ) | |||
|
|
|||
| const isInAddressBook = useMemo( | |||
There was a problem hiding this comment.
Is this checking the eth address or the displayed name of an entry?
There was a problem hiding this comment.
Eth address previously assigned to entry.label
There was a problem hiding this comment.
Thanks! A follow-up question: will it work if I enter a lowercase address but the address book contains a checksummed version of the same address? In some other places we use the sameAddress function for both variants to match.
There was a problem hiding this comment.
You're right hadn't thought of that, I will use the sameAddress function :)
katspaugh
approved these changes
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3531
How this PR fixes it
It adds a memo function value (isInAddressBook) to find address in address book (returns true if found) and adds this check before displaying the message (if not isInAddressBook then display message).
How to test it
Screenshots