Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open info page in new tab #3582

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: open info page in new tab #3582

merged 1 commit into from
Apr 18, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 18, 2024

What it solves

The Learn more button in the Safe Pass banner did not open in a new tab.

How this PR fixes it

  • Sets target to _blank

How to test it

  • Click on Learn more

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

@schmanu schmanu requested a review from jmealy April 18, 2024 16:35
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/home 59.78 KB (🟑 +6 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements
79.07% (-0.02% πŸ”»)
11215/14184
πŸ”΄ Branches
58.55% (-0.02% πŸ”»)
2653/4531
🟑 Functions
66.07% (-0.04% πŸ”»)
1807/2735
🟒 Lines
80.34% (-0.02% πŸ”»)
10105/12578
Show files with reduced coverage πŸ”»
St.❔
File Statements Branches Functions Lines
🟒
... / index.tsx
82.35% (-8.82% πŸ”»)
66.67% (-16.67% πŸ”»)
50% (-12.5% πŸ”»)
83.87% (-9.68% πŸ”»)

Test suite run success

1419 tests passing in 198 suites.

Report generated by πŸ§ͺjest coverage report action from 04d1eca

@schmanu schmanu merged commit 7943666 into dev Apr 18, 2024
14 checks passed
@schmanu schmanu deleted the fix/open-new-tab branch April 18, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants