Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: walletconnect card on dashboard #3616

Merged
merged 6 commits into from
May 8, 2024
Merged

Refactor: walletconnect card on dashboard #3616

merged 6 commits into from
May 8, 2024

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Apr 26, 2024

What it solves

We no longer have to keep the old WalletConnect Safe App visible (WC transations in the history will still get the right icon even though the WC Safe App will be not visible), so I replaced the dashboard widget with a hardcoded WalletConnect card.

Screenshot 2024-04-26 at 14 45 55

Copy link

github-actions bot commented Apr 26, 2024

Copy link

github-actions bot commented Apr 26, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Apr 26, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1006.31 KB (🟡 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/home 59.78 KB (🟡 +7 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Apr 26, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.07% 11233/14206
🔴 Branches 58.55% 2658/4540
🟡 Functions 66.09% 1811/2740
🟢 Lines 80.33% 10118/12595

Test suite run success

1422 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 45f41c3

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion but looks good otherwise!

Copy link

github-actions bot commented Apr 29, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

Verified.
Don't see any problem with hardcoded card even for a new network , as WC should be enabled for any chain

@katspaugh katspaugh merged commit 8f4c07c into dev May 8, 2024
14 checks passed
@katspaugh katspaugh deleted the wc-card branch May 8, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants