-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit batch rpc max count #3630
Conversation
Branch previewβ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
π¦ Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. π€
|
Page | Size (compressed) |
---|---|
global |
1006.32Β KB (π‘ +22Β B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1422 tests passing in 198 suites. Report generated by π§ͺjest coverage report action from cc7392a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
Does it mean that there will be more batches sent?
Yes exactly. With some of my Safes I cannot use CoW Swap anymore as it can not load the balances due to too big batches and Infuras restrictions. This fixes the app for those Safes for me. Ethers will manage the batch size internally. The BrowserProvider for the connected wallet uses a limit of 1 btw disabling batch requests. |
What it solves
When safe apps request many RPC calls, the RPC batch limit of e.g. Infura gets reached on mainnet.
How this PR fixes it
How to test it
Checklist