Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable execute button for pending transactions #3645

Merged
merged 1 commit into from
May 6, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #3644

How this PR fixes it

Disables the execute button if transaction is pending

How to test it

  1. Create and queue a transaction
  2. Execute the transaction
  3. The transaction should be pending
  4. Open the transaction details
  5. Observe the Execute button is disabled

Screenshots

Screenshot 2024-05-02 at 16 05 42

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from katspaugh May 2, 2024 14:05
Copy link

github-actions bot commented May 2, 2024

Copy link

github-actions bot commented May 2, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1006.32 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 75.12 KB (🟡 +45 B) 1.06 MB
/transactions 101.66 KB (🟡 +45 B) 1.08 MB
/transactions/history 101.62 KB (🟡 +45 B) 1.08 MB
/transactions/messages 61.42 KB (🟡 +45 B) 1.04 MB
/transactions/queue 57.08 KB (🟡 +45 B) 1.04 MB
/transactions/tx 46.42 KB (🟡 +45 B) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented May 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.07% (-0% 🔻)
11238/14212
🔴 Branches
58.53% (-0.01% 🔻)
2659/4543
🟡 Functions 66.09% 1811/2740
🟢 Lines
80.33% (-0% 🔻)
10123/12601

Test suite run success

1422 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 0e5fd63

@usame-algan usame-algan requested review from schmanu and removed request for katspaugh May 3, 2024 08:33
@francovenica
Copy link
Contributor

LGTM.
I thougth we had an automation test that was checking this. I'll make a ticket in the automation board

@usame-algan usame-algan merged commit afa8d22 into dev May 6, 2024
14 checks passed
@usame-algan usame-algan deleted the pending-disable-execute branch May 6, 2024 09:21
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute button is enabled for pending transaction
3 participants