-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: resolve Safe address ENS in sidebar #3671
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1008.28 KB (🟡 +188 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/new-safe/create |
32.22 KB (🟢 -181 B) |
1.02 MB |
/new-safe/load |
18.34 KB (🟢 -181 B) |
1 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1425 tests passing in 198 suites. Report generated by 🧪jest coverage report action from 9d78687 |
Looks good Question. Is the scope of this ticket only the sidebar? I noticed that the ENS name is not loaded for the safe in the watchlist (if it is there) like the address book entry does. |
Yes, it's only in this one place. I'm planning to extend it to the Safe List (including the watchlist) but need to check that it's not too many RPC requests. No need for a ticket at this time. |
What it solves
If a Safe doesn't have a name in the Address Book, do a reverse ENS lookup in the Sidebar.
How to test it
Can be tested with the Safe from the PR preview link.
Screenshots