Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: resolve Safe address ENS in sidebar #3671

Merged
merged 1 commit into from
May 8, 2024
Merged

Feat: resolve Safe address ENS in sidebar #3671

merged 1 commit into from
May 8, 2024

Conversation

katspaugh
Copy link
Member

What it solves

If a Safe doesn't have a name in the Address Book, do a reverse ENS lookup in the Sidebar.

How to test it

Can be tested with the Safe from the PR preview link.

Screenshots

Screenshot 2024-05-08 at 09 48 27

@katspaugh katspaugh requested a review from usame-algan May 8, 2024 07:50
Copy link

github-actions bot commented May 8, 2024

Copy link

github-actions bot commented May 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1008.28 KB (🟡 +188 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/new-safe/create 32.22 KB (🟢 -181 B) 1.02 MB
/new-safe/load 18.34 KB (🟢 -181 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented May 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.34% 11319/14267
🔴 Branches 58.73% 2680/4563
🟡 Functions 66.47% 1834/2759
🟢 Lines 80.61% 10194/12646

Test suite run success

1425 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 9d78687

@francovenica
Copy link
Contributor

Looks good

Question. Is the scope of this ticket only the sidebar? I noticed that the ENS name is not loaded for the safe in the watchlist (if it is there) like the address book entry does.
If is not, then I can create a ticket for that and pass this one

@katspaugh
Copy link
Member Author

Yes, it's only in this one place. I'm planning to extend it to the Safe List (including the watchlist) but need to check that it's not too many RPC requests. No need for a ticket at this time.

@katspaugh katspaugh merged commit 788ddaa into dev May 8, 2024
7 of 14 checks passed
@katspaugh katspaugh deleted the ens branch May 8, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants