-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-enable swaps for counterfactual safes [SW-23] #3757
base: dev
Are you sure you want to change the base?
Conversation
Branch previewβ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
π¦ Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. π€ π Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage reportCaution Test run failed
Show files with reduced coverage π»
Test suite run failedFailed tests: 2/1444. Failed suites: 1/199.
Report generated by π§ͺjest coverage report action from 0d15de5 |
CowSwap should now be able to detect once a counterfactual safe is deployed, so we can safely re-enable swaps for counterfactual safes.
8626216
to
0d15de5
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
DRAFT: setting this as draft for now, as the swap widget offers to sign a message instead of submitting a tx and that doesn't work since the safe is not deployed.
What it solves
Cow was not being able to work with counterfactual safes - it was showing the widget as not connected.
Resolves #
Now the widget is connected to the safe and one can submit an order.
How this PR fixes it
How to test it
Screenshots
Checklist