Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve chain switch redirect #3769

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix: improve chain switch redirect #3769

merged 2 commits into from
Jun 4, 2024

Conversation

katspaugh
Copy link
Member

What it solves

After we removed the automatic redirect from /welcome to /welcome/accounts if wallet is connected, the Network Selector started requiring an extra click to see the list of your Safes. This PR fixes that.

The Network Select will now take you straight to /welcome/accounts if wallet is connected.

Copy link

github-actions bot commented May 29, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 29, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.05 KB (🟡 +35 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@francovenica
Copy link
Contributor

Had to read the conversation in the review to understand what it was the purpose of the ticket.

LGTM
Being in a safe of NetworkA and switching to networkB in the top right corner takes the user to the safe selection (/welcome/accounts) instead of the welcome page (/welcome).

It seems this only happens if the user is connected. I think diconnected users also can be taken to the /welcome/accounts page since the user might have safes in his watchlist, but is not a blocker

Copy link

github-actions bot commented Jun 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jun 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.47% (-0.02% 🔻)
11307/14228
🔴 Branches
58.44% (-0.02% 🔻)
2704/4627
🟡 Functions
66.57% (-0.04% 🔻)
1820/2734
🟢 Lines
80.85% (-0.02% 🔻)
10197/12612
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1437 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 645eec6

@katspaugh katspaugh merged commit c8f78c1 into dev Jun 4, 2024
7 of 14 checks passed
@katspaugh katspaugh deleted the chain-redirect branch June 4, 2024 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants