Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for imphash calculation #17

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

secDre4mer
Copy link
Contributor

@secDre4mer secDre4mer commented Mar 7, 2022

Add some fixes where the imphash was calculated incorrectly:

  • Upper case DLL extensions were not removed
  • Missing DLL extensions could cause a panic
  • Ordinal lookups weren't functioning correctly

Add test cases (based on the existing files) that ensure correct functionality.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #17 (5a752c2) into main (29aec65) will increase coverage by 1.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   38.94%   40.00%   +1.05%     
==========================================
  Files          25       25              
  Lines        3425     3427       +2     
==========================================
+ Hits         1334     1371      +37     
+ Misses       1886     1844      -42     
- Partials      205      212       +7     
Impacted Files Coverage Δ
imports.go 59.28% <50.00%> (+5.36%) ⬆️
debug.go 30.43% <0.00%> (+6.76%) ⬆️
ordlookup.go 57.14% <0.00%> (+57.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29aec65...5a752c2. Read the comment docs.

@LordNoteworthy LordNoteworthy merged commit 51c86f8 into saferwall:main Mar 7, 2022
@LordNoteworthy
Copy link
Member

LordNoteworthy commented Mar 7, 2022

Thanks a lot @secDre4mer for those commits, looking good. I have created a new tag that contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants