Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Authentihash, add richHeaderHash #38

Merged
merged 5 commits into from
Jul 1, 2022
Merged

fix Authentihash, add richHeaderHash #38

merged 5 commits into from
Jul 1, 2022

Conversation

wanglei-coder
Copy link
Contributor

Authentihash: refer to https://github.com/ralphje/signify
richHeaderHash: refer to https://github.com/erocarrera/pefile

LordNoteworthy
LordNoteworthy reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@LordNoteworthy LordNoteworthy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a simple typo in richheader_test: RichHeaderHash instead of AuthentiHash.

@LordNoteworthy
Copy link
Member

Great work, well done. I have seen the implementation you did for the authentihash, thank you.

@wanglei-coder
Copy link
Contributor Author

Great work, well done. I have seen the implementation you did for the authentihash, thank you.

You are welcome, because my English is not very good, so the comment is relatively simple.

@LordNoteworthy
Copy link
Member

That's totally fine :) have you seen my review comments?

@LordNoteworthy LordNoteworthy merged commit 605455f into saferwall:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordNoteworthy LordNoteworthy LordNoteworthy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wanglei-coder @LordNoteworthy