Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[config]: Permit more granular control over which data directories are parsed #72

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

rabbitstack
Copy link
Contributor

Parsing every single data directory may incur significant overhead, thus, having more granular control over which data directories are parsed may be desirable. The Options structure got a number of flags to omit parsing specified data directories. This doesn't impact the current behavior - if no fast mode is enabled, all data directories are visited and parsed. Additionally, we can now selectively choose which directories to parse.

Copy link
Member

@LordNoteworthy LordNoteworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a good feature to have, thanks !

Just one typo to fix. otherwise LGTM

file.go Outdated Show resolved Hide resolved
@LordNoteworthy LordNoteworthy added the enhancement New feature or request label Mar 16, 2023
@LordNoteworthy LordNoteworthy merged commit 3952e07 into saferwall:main Mar 17, 2023
@LordNoteworthy
Copy link
Member

Awesome ! Looking good, thanks @rabbitstack !

I am releasing v1.4.0 tomorrow.

@rabbitstack
Copy link
Contributor Author

Thanks for all the effort you're putting into this project. Looking forward for the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants