feat: parse a large number of .NET metadata headers #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support parsing for most of the metadata headers described in ECMA 335 and update/add tests for them. This is intentionally structured to minimize drastic changes to the existing .NET parsing code.
Support parsing for most of the metadata headers described in ECMA 335 and update/add tests for them. This is intentionally structured to minimize drastic changes to the existing .NET parsing code.
Support parsing for most of the metadata headers described in ECMA 335 and update/add tests for them. This is intentionally structured to minimize drastic changes to the existing .NET parsing code.
Support parsing for most of the metadata headers described in ECMA 335 and update/add tests for them. This is intentionally structured to minimize drastic changes to the existing .NET parsing code.
|
Wow ! Outstanding work. Thank you for the extensive unit tests. I run your branch against a large set of PE files, and it passes. Code looks good as well. Merging it ! |
|
v1.4.7 contains this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the PR to support parsing for most metadata headers described in ECMA 335.
We also added many tests and updated a few existing. We tried to intentionally structure this to minimize drastic changes to your existing .NET parsing code.
Feel free to edit this to better fit the project, including removing the debugging Printf in dotnet.net we added for the unhandled tableIndex.
#75