FCS works.

src/Compiler/Driver/ParseAndCheckInputs.fs

@@ -1428,7 +1428,7 @@ let CheckOneInputAux'
 
             match inp with
             | ParsedInput.SigFile file ->
-                printfn $"Processing Sig {file.FileName}"
+                // printfn $"Processing Sig {file.FileName}"
                 let qualNameOfFile = file.QualifiedName
 
                 // Check if we've seen this top module signature before.
@@ -1462,7 +1462,7 @@ let CheckOneInputAux'
 
 
                 // Save info needed for type-checking .fs file later on
-                printfn $"[{Thread.CurrentThread.ManagedThreadId}] Saving fsiBackedInfos for {file.FileName}"
+                // printfn $"[{Thread.CurrentThread.ManagedThreadId}] Saving fsiBackedInfos for {file.FileName}"
                 fsiBackedInfos[file.FileName] <- sigFileType
 
                 // printfn $"Finished Processing Sig {file.FileName}"

tests/ParallelTypeCheckingTests/Code/ASTVisit.fs

@@ -1182,7 +1182,11 @@ module TopModulesExtraction =
                 // Stay safe and as soon as the parent module is reachable, consider this module reachable as well
                 [|LongIdent.Empty|]
             else
-                [|longId|]
+                // 'module A.B' is equivalent to 'namespace A; module B', meaning that 'A' is opened implicitly 
+                if synModuleOrNamespaceKind.IsModule then
+                    [|longId.GetSlice(None, Some <| longId.Length-2); longId|]
+                else
+                    [|longId|]
                 // TODO Temporarily disabled digging into the file's structure to avoid edge cases where another file depends on this file's namespace existing (but nothing else)
                 // synModuleDecls
                 // |> moduleDecls

tests/ParallelTypeCheckingTests/Code/GraphProcessing.fs

@@ -203,6 +203,9 @@ let processGraph<'Item, 'State, 'Result, 'FinalFileResult when 'Item : equality
             }
         finalFileResult, state
 
+    printfn $"Node count: {nodes.Count}"
+    // let mutable cnt = 1
+
     let work
         (node : Node<'Item, StateWrapper<'Item, 'State>, ResultWrapper<'Item, 'Result>>)
         : Node<'Item, StateWrapper<'Item, 'State>, ResultWrapper<'Item, 'Result>>[]
@@ -230,6 +233,16 @@ let processGraph<'Item, 'State, 'Result, 'FinalFileResult when 'Item : equality
                     )
                 pdc = x.Info.Deps.Length
             )
+        // printfn $"State after {node.Info.Item}"
+        // nodes
+        // |> Seq.map (fun (KeyValue(_, v)) ->
+        //     let x = v.Info.Deps.Length - v.ProcessedDepsCount
+        //     $"{v.Info.Item} - {x} deps left"
+        // )
+        // |> Seq.iter (fun x -> printfn $"{x}")
+        // let c = cnt
+        // cnt <- cnt+1
+        // printfn $"Finished processing node. {unblocked.Length} nodes unblocked"
         unblocked
 
     use cts = new CancellationTokenSource()

tests/ParallelTypeCheckingTests/Code/Parallel.fs

@@ -81,18 +81,18 @@ let processInParallel
     (parallelism : int)
     (stop : int -> bool)
     (ct : CancellationToken)
-    (itemToString)
+    (_itemToString)
     : unit
     =
     let bc = new BlockingCollection<'Item>()
     firstItems |> Array.iter bc.Add
     let processedCountLock = Object()
     let mutable processedCount = 0
     let processItem item =
-        printfn $"Processing {itemToString item}"
+        // printfn $"Processing {itemToString item}"
         let toSchedule = work item
         let processedCount = lock processedCountLock (fun () -> processedCount <- processedCount + 1; processedCount)
-        printfn $"ToSchedule {toSchedule.Length}"
+        // printfn $"ToSchedule {toSchedule.Length}"
         toSchedule
         |> Array.iter (
             fun next -> bc.Add(next)

tests/ParallelTypeCheckingTests/Code/ParallelTypeChecking.fs

@@ -2,6 +2,7 @@
 #nowarn "1182"
 open System.Collections.Concurrent
 open System.Collections.Generic
+open System.Threading
 open FSharp.Compiler
 open FSharp.Compiler.CheckBasics
 open FSharp.Compiler.CheckDeclarations
@@ -72,7 +73,7 @@ let CheckMultipleInputsInParallel
     let mutable nextIdx = (graph.Files |> Array.map (fun f -> f.File.Idx.Idx) |> Array.max) + 1
     let fakeX (idx : FileIdx) (fsi : File) : FileData =
         {
-            File = File.FakeFs idx fsi.QualifiedName
+            File = File.FakeFs idx fsi.Name
             Data =
                 {
                     Tops = [||]
@@ -131,6 +132,8 @@ let CheckMultipleInputsInParallel
     // somewhere in the files processed prior to each one, or in the processing of this particular file.
     let priorErrors = checkForErrors ()
 
+    let mutable cnt = 1
+
     let processFile
         (file : File)
         ((input, logger) : ParsedInput * DiagnosticsLogger)
@@ -143,10 +146,11 @@ let CheckMultipleInputsInParallel
             let checkForErrors2 () = priorErrors || (logger.ErrorCount > 0)
 
             let tcSink = TcResultsSink.NoSink
-
+            let c = cnt
+            cnt <- cnt + 1
             match file.AST with
             | ASTOrX.AST _ ->
-                // printfn $"Processing AST {file.ToString()}"
+                printfn $"#{c} [thread {Thread.CurrentThread.ManagedThreadId}] Type-checking {file.ToString()}"
                 let! f = CheckOneInput'(
                     checkForErrors2,
                     tcConfig,
@@ -159,7 +163,7 @@ let CheckMultipleInputsInParallel
                     false  // skipImpFiles...
                 )
 
-                printfn $"Finished Processing AST {file.ToString()}"
+                // printfn $"Finished Processing AST {file.ToString()}"
                 return
                     (fun (state : State) ->
                         // printfn $"Applying {file.ToString()}"
@@ -174,7 +178,7 @@ let CheckMultipleInputsInParallel
                         partialResult, state
                     )
             | ASTOrX.X fsi ->
-                // printfn $"Processing X {file.ToString()}"
+                // printfn $"[{c}] Processing X {file.ToString()}"
 
                 let hadSig = true
                 // Add dummy .fs results
@@ -188,7 +192,6 @@ let CheckMultipleInputsInParallel
                 // Don't use it for this file's type-checking - it will cause duplicates
 
                 let ccuSigForFile = fsiBackedInfos[fsi]
-                printfn $"Finished Processing X {file}"
                 return
                     (fun (state : State) ->
                         // (tcState.TcEnvFromImpls, EmptyTopAttrs, None, ccuSigForFile), state
@@ -236,14 +239,15 @@ let CheckMultipleInputsInParallel
         let _qnof = QualifiedNameOfFile.QualifiedNameOfFile (Ident("", Range.Zero))
         let state: State = tcState, priorErrors
 
+
         let partialResults, (tcState, _) =
             GraphProcessing.processGraph<File, State, SingleResult, FinalFileResult>
                 graph
                 processFile
                 folder
                 state
                 (fun it -> not <| it.Name.EndsWith(".fsix"))
-                8
+                10
 
         partialResults |> Array.toList, tcState
     )

tests/ParallelTypeCheckingTests/Program.fs

@@ -31,6 +31,6 @@ let _parse (argv: string[]): Args =
 [<EntryPoint>]
 let main _argv =
     let args = _parse _argv
-    let args = {args with LineLimit = Some 219}
+    let args = {args with LineLimit = None}
     TestCompilationFromCmdlineArgs.TestCompilerFromArgs args
     0

tests/ParallelTypeCheckingTests/Tests/TestCompilationFromCmdlineArgs.fs

@@ -17,7 +17,7 @@ type Codebase =
 
 let codebases =
     [|
-        { WorkDir = $@"{__SOURCE_DIRECTORY__}\.checkouts\fcs\src\compiler"; Path = $@"{__SOURCE_DIRECTORY__}\FCS.args.txt"; Limit = Some 237 }
+        { WorkDir = $@"{__SOURCE_DIRECTORY__}\.checkouts\fcs\src\compiler"; Path = $@"{__SOURCE_DIRECTORY__}\FCS.args.txt"; Limit = Some 211 }
         { WorkDir = $@"{__SOURCE_DIRECTORY__}\.checkouts\fcs\tests\FSharp.Compiler.ComponentTests"; Path = $@"{__SOURCE_DIRECTORY__}\ComponentTests.args.txt"; Limit = None }
     |]
 

tests/ParallelTypeCheckingTests/Tests/TestDependencyResolution.fs

@@ -1,5 +1,6 @@
 module ParallelTypeCheckingTests.TestDependencyResolution
 #nowarn "1182"
+open System.IO
 open Buildalyzer
 open ParallelTypeCheckingTests
 open ParallelTypeCheckingTests.Types
@@ -116,6 +117,24 @@ type X = Y
     assertGraphEqual deps expectedEdges
 
 
+[<Test>]
+let ``Test error``() =
+    let files =
+        [|
+            "pppars.fs", File.ReadAllText @"C:\projekty\fsharp\heuristic\tests\ParallelTypeCheckingTests\Tests\.checkouts\fcs\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\pppars.fs"
+            "pplex.fs", File.ReadAllText @"C:\projekty\fsharp\heuristic\tests\ParallelTypeCheckingTests\Tests\.checkouts\fcs\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\pplex.fs"
+        |]
+        |> buildFiles
+
+    let deps = DependencyResolution.detectFileDependencies files
+
+    let expectedEdges =
+        [
+            "pplex.fs", ["pppars.fs"]
+        ]
+    assertGraphEqual deps expectedEdges
+
+
 let sampleFiles =
     [
         "Abbr.fs", """