Reject number only entities, as they are ambiguous

safing · Dec 18, 2023 · b76a860 · b76a860
1 parent d6e4c96
commit b76a860
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/profile/endpoints/endpoint-domain.go b/profile/endpoints/endpoint-domain.go
@@ -107,6 +107,12 @@ func parseTypeDomain(fields []string) (Endpoint, error) {
 		domain += "."
 	}
 
+	// Check if this looks like an IP address.
+	// At least the TLDs has characters.
+	if looksLikeAnIP.MatchString(domain) {
+		return nil, nil
+	}
+
 	// Fix domain case.
 	domain = strings.ToLower(domain)
 	needValidFQDN := true

diff --git a/profile/endpoints/endpoint_test.go b/profile/endpoints/endpoint_test.go
@@ -59,6 +59,9 @@ func TestEndpointParsing(t *testing.T) {
 	testParsing(t, "+ * UDP/1234")
 	testParsing(t, "+ * TCP/HTTP")
 	testParsing(t, "+ * TCP/80-443")
+
+	// TODO: Test fails:
+	// testParsing(t, "+ 1234")
 }
 
 func testParsing(t *testing.T, value string) {
@@ -69,6 +72,7 @@ func testParsing(t *testing.T, value string) {
 		t.Error(err)
 		return
 	}
+	// t.Logf("%T: %+v", ep, ep)
 	if value != ep.String() {
 		t.Errorf(`stringified endpoint mismatch: original was "%s", parsed is "%s"`, value, ep.String())
 	}