Skip to content

Commit

Permalink
Improve wording on block bypassing notification and setting
Browse files Browse the repository at this point in the history
  • Loading branch information
dhaavi committed Apr 12, 2022
1 parent 7d2ae68 commit c6ffa51
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 3 additions & 4 deletions compat/notify.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ var (
}

secureDNSBypassIssue = &appIssue{
id: "compat:secure-dns-bypass-%s",
title: "Prevented Bypass Attempt by %s",
message: `[APPNAME] attempted to bypass Portmaster's firewall functions by directly using a Secure DNS resolver. If [APPNAME] experiences problems, disable Secure DNS within [APPNAME] to restore functionality. Rest assured that Portmaster already handles Secure DNS for your whole device, including [APPNAME].
If bypass prevention for [APPNAME] is disabled in Portmaster, it can no longer protect or filter connections coming from [APPNAME].`,
id: "compat:secure-dns-bypass-%s",
title: "Blocked Bypass Attempt by %s",
message: `[APPNAME] is using its own Secure DNS resolver, which would bypass Portmaster's firewall protections. If [APPNAME] experiences problems, disable Secure DNS within [APPNAME] to restore functionality. Rest assured that Portmaster handles Secure DNS for your whole device, including [APPNAME].`,
// TODO: Add this when the new docs page is finished:
// , or [find out about other options](link to new docs page)
level: notifications.Warning,
Expand Down
4 changes: 3 additions & 1 deletion profile/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,9 @@ The lists are automatically updated every hour using incremental updates.
err = config.Register(&config.Option{
Name: "Block Bypassing",
Key: CfgOptionPreventBypassingKey,
Description: `Prevent apps from bypassing the privacy filter.
Description: `Prevent apps from bypassing Portmaster's privacy protections.
If Block Bypassing is disabled, Portmaster can no longer protect you or filter connections from the affected applications.
Current Features:
- Disable Firefox' internal DNS-over-HTTPs resolver
- Block direct access to public DNS resolvers
Expand Down

0 comments on commit c6ffa51

Please sign in to comment.