Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chrome Support] [Research] Adding manifest.json #5

Closed
safwanrahman opened this issue Jun 9, 2016 · 1 comment
Closed

[Chrome Support] [Research] Adding manifest.json #5

safwanrahman opened this issue Jun 9, 2016 · 1 comment

Comments

@safwanrahman
Copy link
Owner

Chrome needs manifest.json to be available in the page while asking for Push notification registration. Otherwise it will throw a error

Uncaught (in promise) DOMException: Registration failed - manifest empty or missing

So for adding support for chrome, we need to add a menifest.json to the directory. An example of menifest.json can be found here. The instruction can be found in MDN

In the menifest.json there is a field for gcm_sender_id. This can be obtained from the google console.
It should be possible for the developer to configure the gcm_sender_id in the settings so that its possible to get it from there.

We should find out a way to get it from settings and generate a json so that it will be possible to load the json in the page with the templatetags

@safwanrahman
Copy link
Owner Author

safwanrahman commented Jun 10, 2016

Fixed with f99c621

safwanrahman added a commit that referenced this issue Jun 10, 2016
The issue raised while updating pywebpush have been fixed while fixing issue #5
so we can just update in setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant