Fixed #16: Better way to store webpush data in DOM

[arogachev]

Fixed #16: Better way to store webpush data in DOM

Additional notes:

• Fixed some code style problems in webpush_notifications.py:
  • Removed unused imports.
  • Fixed indendation.
  • Consistency in quotes usage (single quotes).
  • Fixed dictionary formatting.
• Removed unnecessary spaces around data-group attribute (they already exist around if) in webpush_button.html.
• Removed unncessary linebreaks in webpush.html.

[safwanrahman]

So the fact is that, do everyone will use our webpush button or not. I would be glad if you can find a way to include it in the header.

[arogachev]

I would be glad if you can find a way to include it in the header.

As I said in the issue, including it in header that way is semantically incorrect.

So the fact is that, do everyone will use our webpush button or not.

I think it's premature optimization. Currently extension pretty much forces user to use this button. The current js implementation is very tightly coupled with the button, so user either needs to accept it or rewrite js fully to fit his needs. We can replace data storing element it with hidden input or even leave as div, but what's the point? Everything in current implementation is built on top of this button.

When you decide to make it optional or remove it completely so extension provides only basic subscribing functionality and how to trigger it from interface will be user's decision (should be implemented by him) - that's when you need to worry about it. Along with it you can refactor the way data is passed from server.

And the main goal is to fix incorrect semantics and allow user to register scripts after {% webpush %} tag.

[safwanrahman]

Like you explanation. Thanks @arogachev for explaining. I will review the PR later today

[arogachev]

@safwanrahman OK. I'll add more issues about JS related problems.

[safwanrahman]

Code looks Good. I will check tomorrow in browser then merge it.
Thanks @arogachev for the Pull Request

[safwanrahman]

Sorry, could not get time. going to do it tomorrow, Friday (Week end here)

[safwanrahman]

Sorry for the delay. It was quite a busy week!
I have tested in and it works without any problem.
So lets merge it!
Thanks @arogachev