Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n Support #89

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Add i18n Support #89

merged 1 commit into from
Mar 6, 2021

Conversation

rcmurphy
Copy link
Contributor

  • Adds i18n support
  • Makes some small grammatical / phrasing tweaks to existing messages.

@safwanrahman
Copy link
Owner

Thanks for the PR! But I was wondering if we should keep the .po file in package! I do not have any idea about localization in django package.

@rcmurphy
Copy link
Contributor Author

rcmurphy commented Dec 2, 2020

My understanding is yes, we should check in the mo and po files, as the po files are what actually drive it... Otherwise you need to run django-admin compilemessages before starting.

@rcmurphy
Copy link
Contributor Author

rcmurphy commented Dec 25, 2020

Gentle bump!

Here is an example of a larger project with both MO and PO files checked in.

@ahivert
Copy link

ahivert commented Feb 25, 2021

Yes the package should store po/mo files, you can check how Wagtail (django CMS) handle that.
https://github.com/wagtail/wagtail/tree/master/wagtail/locales/locale

To make this PR complete maybe we can add at least another language to have at least one example. I can do French one as I am going to need it :)

@mambasoft
Copy link

Hi, I'm also interested in this feature and can provide italian translations. Thanks!

@safwanrahman
Copy link
Owner

This looks good to me! Sorry it took so long to get it merged. I had some busy time last couple of months, so could not lookover the projects. Thanks @rcmurphy 💯🚀

@safwanrahman safwanrahman merged commit a526695 into safwanrahman:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants