Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set background colour in SASS #1490

Closed
GreenImp opened this issue Sep 2, 2021 · 1 comment · Fixed by #1528
Closed

Unable to set background colour in SASS #1490

GreenImp opened this issue Sep 2, 2021 · 1 comment · Fixed by #1528

Comments

@GreenImp
Copy link

GreenImp commented Sep 2, 2021

Describe the bug
The background of the component is set to none, so it cannot be modified through the use of SASS variables.
I see that you mentioned it here: #825 (comment)

I just noticed this line:

.vs__dropdown-toggle {
  appearance: none;
  display: flex;
  padding: 0 0 4px 0;
  background: none;
  border: $border-width $border-style $border-color;
  border-radius: $border-radius;
  white-space: normal;
}

Looks like background:none; made it's way into v3. I'll get an update pushed for that.

However, it looks like fixing this slipped through the cracks!

To Reproduce
Have a look at the SASS file:

.vs__dropdown-toggle {
appearance: none;
display: flex;
padding: 0 0 4px 0;
background: none;
border: $border-width $border-style $border-color;
border-radius: $border-radius;
white-space: normal;
}

Expected behavior
To be able to modify the background colour via SASS variables.

@github-actions
Copy link

🎉 This issue has been resolved in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants