Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases don't provide dist/ #70

Closed
stephane opened this issue Jun 28, 2016 · 5 comments
Closed

Releases don't provide dist/ #70

stephane opened this issue Jun 28, 2016 · 5 comments

Comments

@stephane
Copy link

To ease integration of your component in various toolchains, could you provide /dist with each release (as done for Vue.js https://github.com/vuejs/vue/tree/dev/dist)?

To give you another example, my toolchain doesn't support Vue files (.vue) so I can't build your component. Providing built files, it's also a way to ensure your component is properly built (you can control the distribution).

@sagalbot
Copy link
Owner

Originally I built this out with the thought that most peoples build process would include vueify/vue-loader, but as it's grown that is certainly no longer the case. I agree that providing the built files will be a much better route, and it is a good solution to #57 and #69.

This is my top priority at the moment as #57 and #69 are critical. I'm just coming back to work now after a nasty concussion so progress has been much slower than usual.

@sagalbot
Copy link
Owner

sagalbot commented Jul 4, 2016

@stephane v1.3.0 now includes a built and minified version of the component at /dist/vue-select.js.

@sagalbot sagalbot closed this as completed Jul 4, 2016
@fission6
Copy link

fission6 commented Jul 6, 2016

@stephane were you able to get this to work using the new dist, would love a fiddle example!

I am not sure how to access the dist, it doesn't seem to find the v-select component and spits an error out in the console.

@stephane
Copy link
Author

stephane commented Jul 6, 2016

I just do:

npm install vue-select --save

import vSelect from 'vue-select'

const FooComponent = {
  components: {
    vSelect
  }
  data: function() {
    return {
      options: ['foo', 'bar'],
      selected: null
    }
  }
}

and v-select markup is available in my template.

I use Babel (ES6).

@fission6
Copy link

fission6 commented Jul 6, 2016

right but i am not using any tools chains which makes it very hard to
follow your example

I was hoping for a simple straight JS example that would be amazing! Really
exciting to try ad use this.

On Wed, Jul 6, 2016 at 10:29 AM Stéphane Raimbault notifications@github.com
wrote:

I just do:

npm install vue-select --save

``
import vSelect from 'vue-select'

const FooComponent = {
components: {
vSelect
}
data: function() {
return {
options: ['foo', 'bar'],
selected: null
}
}
}

andv-select`` markup is available in my template.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#70 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAY9UjYcI_rn2zKmLjHHd6vGTbNGknzBks5qS7vHgaJpZM4JAKE4
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants