Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 upgrade #1309

Merged
merged 42 commits into from Dec 28, 2020
Merged

Vue 3 upgrade #1309

merged 42 commits into from Dec 28, 2020

Conversation

wolfjagger
Copy link

Related issues & PRs I can find: #1251 #1286 #1289 #1307.

Upgrad vue to 3.
Upgrade vue-related packages. This uses several beta packages, so I don't know how we feel about that.
Event API breaking changes (emits, modelValue, ...).
Change 'propsData' to 'props'.
Change 'scopedSlots' to 'slots'.
Update dev.js with createApp breaking change.
Adjust webpack build for vue 3 (change vue alias to esm-bundler, add environment define variables).
Set vue as external library so it's not bundled in.
Add prepare script (can remove, just was helpful for testing).

dependabot bot and others added 30 commits September 18, 2020 12:48
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](http-party/node-http-proxy@1.18.0...1.18.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1281)

Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](http-party/node-http-proxy@1.18.0...1.18.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wolfjagger
Copy link
Author

There are two changes #1289 makes that I do not:

Select.vue:748 they change from this.$refs['deselectButtons'] to document.querySelectorAll('.vs__deselect').
Select.vue:985 they change from this.$options.propsData.hasOwnProperty('reduce'); to typeof this.reduce === 'function';.

I assume both of these changes are for good reason, but I have not looked into it.

@sagalbot
Copy link
Owner

This was a ton of valuable work @wolfjagger and I really appreciate it! Do you recall why typescript needed to be added as a dev dep?

@sagalbot sagalbot merged commit 910adc0 into sagalbot:feat/vue-3-compat Dec 28, 2020
@j2L4e
Copy link

j2L4e commented Jun 17, 2021

Select.vue:985 they change from this.$options.propsData.hasOwnProperty('reduce'); to typeof this.reduce === 'function';.

this.$options.props.hasOwnProperty('reduce') always throws, because $options.props doesn't have a prototype (at least for Vue 3.1.1). And if it worked, it would always evaluate to true, because the reduce prop is defined on the very component.
typeof this.reduce === 'function' checks if there's a function passed in as a prop. Which seems odd, because it has a default of () => {}.

isTrackingValues () could really use a comment on how it actually determines if it isTrackingValues

@sagalbot sagalbot linked an issue Jun 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI doesn't update with selected value
4 participants