Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set !default for $vs-controls-deselect-text-shadow #1468

Merged
merged 1 commit into from Jul 30, 2021

Conversation

donni106
Copy link
Contributor

  • added missing !default for $vs-controls-deselect-text-shadow, which was the only one not having it
  • !default is necessary in order to be able override the variable

Resolves #1467

- added missing `!default` for $vs-controls-deselect-text-shadow,
  which was the only one not having it
- `!default` is necessary in order to be able override the variable
@sagalbot sagalbot merged commit 0f763f3 into sagalbot:master Jul 30, 2021
@sagalbot
Copy link
Owner

Thanks @donni106!

@github-actions
Copy link

🎉 This PR is included in version 3.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

sagalbot added a commit that referenced this pull request Aug 1, 2021
commit 23feaad
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:45:49 2021 -0700

    Update package.json

commit 69d11c7
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:42:38 2021 -0700

    update eslint config

commit 96819eb
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Fri Jul 30 11:01:59 2021 -0700

    build: add prettier and eslint (#1090)

commit f702040
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Fri Jul 30 00:38:55 2021 +0000

    chore(🚀): 3.12.2

commit 0f763f3
Author: Daniel Molnar <dm@tpwd.de>
Date:   Fri Jul 30 02:37:49 2021 +0200

    fix: set !default for $vs-controls-deselect-text-shadow (#1468)

    - added missing `!default` for $vs-controls-deselect-text-shadow,
      which was the only one not having it
    - `!default` is necessary in order to be able override the variable

commit 335920b
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Jul 22 21:41:39 2021 +0000

    chore(🚀): 3.12.1

commit 5e1ac1f
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Thu Jul 22 14:40:29 2021 -0700

    fix: no-options slot should use mutableLoading instead of loading prop (#1465)
sagalbot added a commit to klausapp/vue-select that referenced this pull request Oct 17, 2021
commit 23feaad
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:45:49 2021 -0700

    Update package.json

commit 69d11c7
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:42:38 2021 -0700

    update eslint config

commit 96819eb
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Fri Jul 30 11:01:59 2021 -0700

    build: add prettier and eslint (sagalbot#1090)

commit f702040
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Fri Jul 30 00:38:55 2021 +0000

    chore(🚀): 3.12.2

commit 0f763f3
Author: Daniel Molnar <dm@tpwd.de>
Date:   Fri Jul 30 02:37:49 2021 +0200

    fix: set !default for $vs-controls-deselect-text-shadow (sagalbot#1468)

    - added missing `!default` for $vs-controls-deselect-text-shadow,
      which was the only one not having it
    - `!default` is necessary in order to be able override the variable

commit 335920b
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Jul 22 21:41:39 2021 +0000

    chore(🚀): 3.12.1

commit 5e1ac1f
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Thu Jul 22 14:40:29 2021 -0700

    fix: no-options slot should use mutableLoading instead of loading prop (sagalbot#1465)

commit d648a1f
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Jul 22 20:52:47 2021 +0000

    chore(🚀): 3.12.0

commit 1676947
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Thu Jul 22 13:51:43 2021 -0700

    feat: add dropdownShouldOpen prop (sagalbot#1464)

commit 94549ff
Author: Alexander Karlstad <alexander.karlstad@gmail.com>
Date:   Thu Jul 22 22:35:07 2021 +0200

    docs: Add search event to documentation (sagalbot#1342)

    * Add search event to documentation

    * Fix jsdoc for other event examples

    * Add toggleLoading param to documentation

    * Update events.md

    Co-authored-by: Jeff Sagal <sagalbot@gmail.com>

commit 86dd03d
Author: Can Geliş <geliscan@gmail.com>
Date:   Thu Jul 22 23:22:52 2021 +0300

    docs: add open and close events to the documentation (sagalbot#1366)

    * add open and close events to the documentation
    * Update events.md

    Co-authored-by: Jeff Sagal <sagalbot@gmail.com>

commit 7d59ab2
Author: Kevin Cameron <kevinacameron@hotmail.com>
Date:   Thu Jul 22 13:18:31 2021 -0700

    docs: Fix typo (sagalbot#1374)

commit 7da3ad4
Author: George Catalin <44193533+rsgcata@users.noreply.github.com>
Date:   Thu Jul 22 23:15:18 2021 +0300

    docs: add missing @search event sagalbot#1417

commit 2e8dd91
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Tue Jul 20 09:20:23 2021 -0700

    docs: update sponsors, remove ads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scss variable $vs-controls-deselect-text-shadow is not a !default?
2 participants