Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force to run in vue3 mode when using @vue/compat #1668

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

walmon
Copy link

@walmon walmon commented Aug 3, 2022

When users run vue-select in @vue/compat build with default to vue 2, some events will not work (such as update:modelValue as reported here.

Fix comes from official docs: https://v3-migration.vuejs.org/migration-build.html#per-component-config

Should not impact environment that are not running the compatibility build.

When users run vue-select in @vue/compat mode with default to vue 2, some events will not work

Fix comes from official docs: https://v3-migration.vuejs.org/migration-build.html#per-component-config

Should not impact environment that are not running the compatibility build.
@netlify
Copy link

netlify bot commented Aug 3, 2022

👷 Deploy request for vueselect accepted.

Name Link
🔨 Latest commit 5cf8806
🔍 Latest deploy log https://app.netlify.com/sites/vueselect/deploys/62ea9443000b520008b3a871

@walmon walmon mentioned this pull request Aug 3, 2022
26 tasks
@sagalbot sagalbot changed the title force to run in vue3 mode when using @vue/compat fix: force to run in vue3 mode when using @vue/compat Aug 23, 2022
@sagalbot sagalbot merged commit e1bfaee into sagalbot:beta Aug 23, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants