-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL support #274
Add RTL support #274
Conversation
@@ -796,7 +818,8 @@ | |||
searching: this.searching, | |||
searchable: this.searchable, | |||
unsearchable: !this.searchable, | |||
loading: this.mutableLoading | |||
loading: this.mutableLoading, | |||
rtl: this.rtl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this here. The data properties above it are all modified internally by the component. Since props are immutable, they are proxied to mutable values here.
Since vue-select has no reason to change rtl
, we don't need to create a mutable data property for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't recall making it mutable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have it defined as both a prop, and a data key, both with the rtl
key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really strange, you'd get an error from Vue. IIRC, I set it as prop and then added it to the dropdownClasses
computed prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah! I've reviewed too many PRs today.. The way github presented the changes totally makes it look like it was in data
, but yeah, it's in dropdownClasses()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it appeared like that for me as well. Kinda confusing, mysterious ways of the Github.
This has been on the list a long time. Thank you! |
Changed the API a bit here. I liked your implementation because it's quick: |
I assigned the |
Yep, any <v-select taggable></v-select> Pretty handy. Anyways, here's the final API for this: <v-select dir="rtl"></v-select>
<v-select dir="ltr"></v-select>
<v-select dir="auto"></v-select> // default I replaced the |
Oh. Didn't know that one. Slick. Silly me. Didn't notice the |
Adds #39